Register subdirectory events on directory load #24781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the propagation issue of nested subdirectory creation and deletion events during snapshot loads. Key changes include adding a new test to validate event registration on load, integrating event registration within subdirectory population, and fixing a spelling typo in the comments.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/dds/map/src/test/mocha/directory.spec.ts | Added a new test case to verify that subdirectory events propagate. |
| packages/dds/map/src/directory.ts | Registered subdirectory events on load and fixed a spelling typo. |
Comments suppressed due to low confidence (1)
packages/dds/map/src/directory.ts:2017
- [nitpick] A brief inline comment explaining the purpose of calling registerEventsOnSubDirectory here would improve code clarity.
this.registerEventsOnSubDirectory(newSubDir, subdirName);
| assert(subdir, "child subdirectory should exist"); | ||
|
|
||
| let subDirectoryCreatedEventCounts = 0; | ||
| loadedDirectory.on("subDirectoryCreated", (path, _local, _target) => { |
There was a problem hiding this comment.
[nitpick] Consider using assert.strictEqual for validating event count values to ensure a type-safe comparison, in line with other assertions in this test file.
Copilot uses AI. Check for mistakes.
anthony-murphy
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading from snapshot, nested subdirectory create and delete events do not propagate. This change registers the events on load. AB#39281