Remove fallback call for redeeming sharing link in ODSP driver which was just added as a precaution when main network was added. #24790
+16
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the fallback call for redeeming a sharing link in the ODSP driver, streamlining the snapshot fetching process.
- Removed the fallback test case for redeeming sharing link using the siteUrl.
- Updated the redeemSharingLink function to remove the redundant fallback call and integrate telemetry event handling.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/drivers/odsp-driver/src/test/fetchSnapshot.spec.ts | Removed the test case for fallback behavior that is no longer required. |
| packages/drivers/odsp-driver/src/fetchSnapshot.ts | Removed the fallback call and updated telemetry event handling in the redeemSharingLink function. |
Comments suppressed due to low confidence (2)
packages/drivers/odsp-driver/src/test/fetchSnapshot.spec.ts:567
- [nitpick] The test case for fallback behavior has been removed; please ensure that all necessary scenarios regarding sharing link redemption are adequately covered elsewhere.
it("RedeemFallback behavior when fallback succeeds with using siteUrl", async () => {
packages/drivers/odsp-driver/src/fetchSnapshot.ts:264
- [nitpick] The fallback call using the siteUrl has been removed as intended. Please confirm that error handling and telemetry capture fully address all failure scenarios without the fallback.
await callSharesAPI(odspResolvedUrl.siteUrl);
markfields
reviewed
Jun 9, 2025
| const disableUsingTenantDomain = loggerToMonitoringContext(logger).config.getBoolean( | ||
| "Fluid.Driver.Odsp.DisableUsingTenantDomainForSharesApi", | ||
| ); | ||
| const details = JSON.stringify({ |
There was a problem hiding this comment.
nit (optional): You don't need JSON.stringify here, the logger will do that for you before sending.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove fallback call for redeeming sharing link which was added as a precaution.