Skip to content

Implement Access Control for Historian Endpoints #24839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sonalideshpandemsft
Copy link
Contributor

No description provided.

@github-actions github-actions bot added area: server Server related issues (routerlicious) base: main PRs targeted against main branch labels Jun 12, 2025
@sonalideshpandemsft sonalideshpandemsft force-pushed the enforce-access-control-historian branch from f87b5e4 to 50569e1 Compare June 12, 2025 16:39
@sonalideshpandemsft sonalideshpandemsft marked this pull request as ready for review June 16, 2025 18:35
Copy link
Contributor

@shubhi1092 shubhi1092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I am wondering why only some endpoints need this check and not all?

@sonalideshpandemsft
Copy link
Contributor Author

sonalideshpandemsft commented Jun 18, 2025

Looks good, but I am wondering why only some endpoints need this check and not all?

Just confimed this with the testing devs, all historian endpoints should have scopes except /ping. Updated the PR to reflect the same.

@sonalideshpandemsft sonalideshpandemsft enabled auto-merge (squash) June 18, 2025 18:12
@sonalideshpandemsft sonalideshpandemsft merged commit cb62513 into microsoft:main Jun 18, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: server Server related issues (routerlicious) base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants