Skip to content

LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250604192236101 to main #61815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

csigs
Copy link
Member

@csigs csigs commented Jun 4, 2025

LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250604192236101 to main with localized lcls

@Copilot Copilot AI review requested due to automatic review settings June 4, 2025 19:22
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Jun 4, 2025
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 4, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates diagnostic messages in various localization files to include "or class static initialization blocks" as part of the error message when referencing 'arguments' in specific contexts.

  • Updated the ItemId for the error message to reflect the new error context.
  • Revised the error message text in multiple languages to include class static initialization blocks.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/loc/lcl/trk/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated error message text and ItemId for the Turkish locale.
src/loc/lcl/rus/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated error message text and ItemId for the Russian locale.
src/loc/lcl/ptb/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated error message text and ItemId for the Portuguese (Brazil) locale.
src/loc/lcl/plk/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated error message text and ItemId for the Polish locale.
src/loc/lcl/kor/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated error message text and ItemId for the Korean locale.
src/loc/lcl/jpn/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated error message text and ItemId for the Japanese locale.
src/loc/lcl/ita/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated error message text and ItemId for the Italian locale.
src/loc/lcl/fra/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated error message text and ItemId for the French locale.
src/loc/lcl/esn/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated error message text and ItemId for the Spanish locale.
src/loc/lcl/deu/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated error message text and ItemId for the German locale.
src/loc/lcl/csy/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated error message text and ItemId for the Czech locale.
src/loc/lcl/cht/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated error message text and ItemId for the Traditional Chinese locale.
src/loc/lcl/chs/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated error message text and ItemId for the Simplified Chinese locale.
Comments suppressed due to low confidence (13)

src/loc/lcl/trk/diagnosticMessages/diagnosticMessages.generated.json.lcl:18398

  • Ensure the updated ItemId and error message text accurately convey the inclusion of class static initialization blocks for the Turkish locale.
<Item ItemId=";arguments_cannot_be_referenced_in_property_initializers_or_class_static_initialization_blocks_2815" ItemType="0" PsrId="306" Leaf="true">

src/loc/lcl/rus/diagnosticMessages/diagnosticMessages.generated.json.lcl:18404

  • Verify that the Russian translation properly reflects the new combined error condition, including class static initialization blocks.
<Item ItemId=";arguments_cannot_be_referenced_in_property_initializers_or_class_static_initialization_blocks_2815" ItemType="0" PsrId="306" Leaf="true">

src/loc/lcl/ptb/diagnosticMessages/diagnosticMessages.generated.json.lcl:18395

  • Confirm that the Portuguese (Brazil) error message update correctly includes both property initializers and class static initialization blocks.
<Item ItemId=";arguments_cannot_be_referenced_in_property_initializers_or_class_static_initialization_blocks_2815" ItemType="0" PsrId="306" Leaf="true">

src/loc/lcl/plk/diagnosticMessages/diagnosticMessages.generated.json.lcl:18392

  • Check that the Polish locale update provides a clear message combining both property initializer and static initialization block references.
<Item ItemId=";arguments_cannot_be_referenced_in_property_initializers_or_class_static_initialization_blocks_2815" ItemType="0" PsrId="306" Leaf="true">

src/loc/lcl/kor/diagnosticMessages/diagnosticMessages.generated.json.lcl:18405

  • Ensure the Korean translation update reflects the extended error condition, listing both property initializers and class static initialization blocks.
<Item ItemId=";arguments_cannot_be_referenced_in_property_initializers_or_class_static_initialization_blocks_2815" ItemType="0" PsrId="306" Leaf="true">

src/loc/lcl/jpn/diagnosticMessages/diagnosticMessages.generated.json.lcl:18405

  • Verify that the updated Japanese message effectively communicates the inclusion of class static initialization blocks alongside property initializers.
<Item ItemId=";arguments_cannot_be_referenced_in_property_initializers_or_class_static_initialization_blocks_2815" ItemType="0" PsrId="306" Leaf="true">

src/loc/lcl/ita/diagnosticMessages/diagnosticMessages.generated.json.lcl:18405

  • Confirm that the Italian localization correctly incorporates the new error context in its updated message.
<Item ItemId=";arguments_cannot_be_referenced_in_property_initializers_or_class_static_initialization_blocks_2815" ItemType="0" PsrId="306" Leaf="true">

src/loc/lcl/fra/diagnosticMessages/diagnosticMessages.generated.json.lcl:18417

  • Ensure the French translation update clearly states that references to 'arguments' are disallowed in both property initializers and static initialization blocks.
<Item ItemId=";arguments_cannot_be_referenced_in_property_initializers_or_class_static_initialization_blocks_2815" ItemType="0" PsrId="306" Leaf="true">

src/loc/lcl/esn/diagnosticMessages/diagnosticMessages.generated.json.lcl:18417

  • Double-check that the Spanish localization accurately reflects the new combined error condition for both property initializers and static initialization blocks.
<Item ItemId=";arguments_cannot_be_referenced_in_property_initializers_or_class_static_initialization_blocks_2815" ItemType="0" PsrId="306" Leaf="true">

src/loc/lcl/deu/diagnosticMessages/diagnosticMessages.generated.json.lcl:18399

  • Review the German error message update to ensure that it consistently includes both property initializers and class static initialization blocks.
<Item ItemId=";arguments_cannot_be_referenced_in_property_initializers_or_class_static_initialization_blocks_2815" ItemType="0" PsrId="306" Leaf="true">

src/loc/lcl/csy/diagnosticMessages/diagnosticMessages.generated.json.lcl:18414

  • Ensure the Czech localization update properly communicates the extended error context including static initialization blocks.
<Item ItemId=";arguments_cannot_be_referenced_in_property_initializers_or_class_static_initialization_blocks_2815" ItemType="0" PsrId="306" Leaf="true">

src/loc/lcl/cht/diagnosticMessages/diagnosticMessages.generated.json.lcl:18405

  • Confirm that the Traditional Chinese translation update correctly reflects both property initializer and class static initialization block restrictions.
<Item ItemId=";arguments_cannot_be_referenced_in_property_initializers_or_class_static_initialization_blocks_2815" ItemType="0" PsrId="306" Leaf="true">

src/loc/lcl/chs/diagnosticMessages/diagnosticMessages.generated.json.lcl:18405

  • Verify that the Simplified Chinese localization message correctly states that 'arguments' cannot be referenced in both property initializers and static initialization blocks.
<Item ItemId=";arguments_cannot_be_referenced_in_property_initializers_or_class_static_initialization_blocks_2815" ItemType="0" PsrId="306" Leaf="true">

@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Jun 4, 2025
@jakebailey jakebailey merged commit 2b88aeb into main Jun 4, 2025
32 checks passed
@jakebailey jakebailey deleted the lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250604192236101 branch June 4, 2025 19:51
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants