Fix VSIX extension ID extraction for updateTasksId when extensionId input not provided #1217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
updateTasksId
feature couldn't derive the extension ID from VSIX-packaged extensions when theextensionId
input parameter was not explicitly provided. This caused task IDs to be generated usingundefined
instead of the actual extension ID from the VSIX file.Root Cause
The code was reading the extension ID from
extension.vsomanifest
(JSON format), but this file doesn't contain the actual extension ID - it only has contribution metadata. The real extension ID is stored inextension.vsixmanifest
(XML format).Solution
Added a new
getVsixExtensionId()
function that:.vsomanifest
and.vsixmanifest
)The extension ID resolution now follows this priority:
extensionId
input parameter (highest priority - existing behavior)extension.vsixmanifest
) - NEWextension.vsomanifest
) - fallback (existing behavior)Changes
getVsixExtensionId()
function in both versionsupdateTaskManifests()
to use VSIX extension ID when availableTesting
Created comprehensive tests that demonstrate:
undefined
(broken)my-awesome-extension
from VSIX manifestextensionId
input is providedImpact
This fix ensures that
updateTasksId
works correctly for VSIX-packaged extensions without requiring users to manually specify theextensionId
parameter, as the extension ID can now be automatically derived from the VSIX file itself.Fixes #205.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.