Skip to content

Avoid dynamic allocation in jit boolean return stub #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

0xb-s
Copy link
Contributor

@0xb-s 0xb-s commented Jun 14, 2025

Use fixed-sized buffer in generate_will_return_boolean_jit_code

@mazong1123
Copy link
Collaborator

Thanks for making the change! I'll find some time next week to review it.

Copy link
Collaborator

@mazong1123 mazong1123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Minor style issue.

@mazong1123
Copy link
Collaborator

Could you change the parameter name so it' good to merge? Thanks!

@0xb-s
Copy link
Contributor Author

0xb-s commented Jun 22, 2025

Could you change the parameter name so it' good to merge? Thanks!

Done ! Thanks!

@0xb-s 0xb-s requested a review from mazong1123 June 22, 2025 14:50
@0xb-s 0xb-s requested a review from mazong1123 June 23, 2025 09:04
Copy link
Collaborator

@mazong1123 mazong1123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mazong1123 mazong1123 merged commit a74707e into microsoft:main Jun 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants