Skip to content

Extension: add Smart Solder Kit #6314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

martinwork
Copy link
Contributor

@abchatra abchatra enabled auto-merge (squash) June 18, 2025 20:27
@abchatra
Copy link
Collaborator

@ssande-fwd I am confused. There is no code in this extension and it is just dependent on Forward-Education/pxt-fwd-modules/fwd-solder-3b3l. Why not just add that extension to approved list?

@ssande-fwd
Copy link

Our product ecosystem has collections of jacdac modules. In order to allow those collections to exist independently and overlap and intertwine gracefully I am following a 3 layer architecture. It's outlined in the pxt-fwd-modules readme. The user facing extension layer doesn't introduce functionality. It groups together existing functionalities and hosts tutorial content. A side effect of this architecture is this somewhat silly situation where one of our products only depends on one module. I could break the design but then we have non-coders working on tutorials in a repo with code and increased complexity of sharing modules among different products (user facing extensions), to name a couple downsides. Instead I'm following the architecture and keeping my life simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants