feat(fips): Fix Dropreason plugin in FIPS #1499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rectified95
reviewed
Apr 1, 2025
rectified95
reviewed
Apr 1, 2025
| dr.l.Warn("inet_csk_accept not found, skipping attaching kretprobe to it. This may impact the drop reason metrics.") | ||
| } else { | ||
| dr.l.Error("opening kretprobe: %w", zap.Error(err)) | ||
| return err |
There was a problem hiding this comment.
Need sth like this to address the error linter issue:
return fmt.Errorf("Failed to attach program: %w", err) //nolint:goerr113 //wrapping error from external module
if you wrap the error as it asks, and is good practice, you'll get an error from a different linter, whihch is a false positive; i faced this in another PR
|
This PR will be closed in 7 days due to inactivity. |
github-actions
bot
added
the
meta/waiting-for-author
|
Superseded by #1600 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In FIPs complient *nix nodes,
dropreasonplugin was failing to install. Also, therlimitcommand fails to run due to insufficient permission. This PR fixes thedropreasonplugin and adds the necessary permission to run therlimitcommandRelated Issue
#1439
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.