invalid URL escape panic when creating new file in WSL

[jakebailey]

Honestly, this seems like a VS Code / WSL bug more than anything, but I was in the editor, then created a new file with code-insiders path/to/file, and got:

panic handling request textDocument/didOpen parse "untitled://wsl%2Bubuntu/home/jabaile/work/TypeScript/tests/cases/compiler/missingDiscriminants.ts": invalid URL escape "%2B" goroutine 34 [running]:
runtime/debug.Stack()
	runtime/debug/stack.go:26 +0x5e
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop.func1.1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:357 +0x5d
panic({0xa39000?, 0xc010f56510?})
	runtime/panic.go:792 +0x132
github.com/microsoft/typescript-go/internal/core.Must[...](...)
	github.com/microsoft/typescript-go/internal/core/core.go:408
github.com/microsoft/typescript-go/internal/ls.DocumentURIToFileName({0xc0017d8070?, 0x0?})
	github.com/microsoft/typescript-go/internal/ls/converters.go:84 +0x25a
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleDidOpen(0xc0001aea20, {0xa8000a?, 0xc002a09d70?}, 0x414a1e?)
	github.com/microsoft/typescript-go/internal/lsp/server.go:598 +0x46
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleRequestOrNotification(0x7907a4e955a8?, {0xccd890?, 0xc0000d8a50?}, 0xc000600808?)
	github.com/microsoft/typescript-go/internal/lsp/server.go:464 +0x10e
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop.func1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:363 +0x75
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop(0xc0001aea20, {0xccd890?, 0xc000218000?})
	github.com/microsoft/typescript-go/internal/lsp/server.go:379 +0x4bb
github.com/microsoft/typescript-go/internal/lsp.(*Server).Run.func1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:255 +0x1f
golang.org/x/sync/errgroup.(*Group).add.func1()
	golang.org/x/sync@v0.14.0/errgroup/errgroup.go:130 +0x7e
created by golang.org/x/sync/errgroup.(*Group).add in goroutine 1
	golang.org/x/sync@v0.14.0/errgroup/errgroup.go:98 +0x76

And alas:

[Trace - 9:01:17 AM] Sending notification 'textDocument/didOpen'.
Params: {
    "textDocument": {
        "uri": "untitled://wsl%2Bubuntu/home/jabaile/work/TypeScript/tests/cases/compiler/missingDiscriminants.ts",
        "languageId": "typescript",
        "version": 1,
        "text": ""
    }
}

This crashed 5 times, as VS Code kept sending this URI ☹

It shouldn't crash. Probably, worth doing some weird fixup on to turn into a file://. I dunno.

[jakebailey]

I'm going to treat this as a problem in tsgo; Go's url.Parse is not happy with this escaping, while VS Code and even new URL are. I guess this is a place where the three specs disagree.

[jrieken]

@jakebailey in VS Code, when getting the string of a uri you ask it to skip encoding with Uri.toString(true). This might work for you and in general is a good way to exchange uris with other tools/libs.

[jakebailey]

I don't think we have the ability to do that. Our extension just uses vscode-languageserver-node. We never interact with URIs client-side, and on the server side we have no choice but to deal with whatever string is sent over.