-
Notifications
You must be signed in to change notification settings - Fork 637
Add support for resolution mode #851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
62d765c
to
646a75a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds support for resolution mode across various modules of the project. Key changes include updating APIs to accept a resolution mode parameter (e.g. in fakeProgram, Program, and Resolver), modifying error baselines and import resolution behavior in test files, and introducing new helper functions in the compiler options, module utilities, and AST utilities.
Reviewed Changes
Copilot reviewed 600 out of 600 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
testdata/baselines/reference/submodule/compiler/*.diff | Removal/updating of error baseline files to reflect new resolution mode behavior. |
internal/transformers/importelision_test.go | Updates to fakeProgram with new resolution mode methods and added stub implementations. |
internal/module/resolver.go | Renaming of GetPackageJsonTypeIfApplicable to GetPackageJsonScopeIfApplicable and slight behavior updates. |
internal/core/compileroptions.go | New functions to expose package json exports/imports and TS extension import options. |
internal/compiler/program.go & fileloader.go | Updated signatures in GetResolvedModule and added new methods for retrieving resolution mode and file meta data. |
internal/checker/* & internal/ast/* | Adjustments to incorporate resolution mode in module resolution logic and type-checking. |
Looking at the error diffs that got modified but not deleted, a few big categories stand out:
|
...baselines/reference/submoduleAccepted/conformance/importTag15(module=esnext).errors.txt.diff
Outdated
Show resolved
Hide resolved
081778a
to
45fd7b7
Compare
No description provided.