Skip to content

[mcp-servers] Switch the header example to something more likely #8437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

julien-c
Copy link

@julien-c julien-c commented Jun 2, 2025

i expect most keys will be passed as Authorization: Bearer headers, so this would make the doc simpler to understand

@isidorn
Copy link
Contributor

isidorn commented Jun 2, 2025

Thank you. Makes sense. Though let's see if @digitarald or @connor4312 have any feedback.

@connor4312
Copy link
Member

I'm fine keeping the example header as API_KEY. Specifically for authorization, newly implemented servers should tend to use MCP's Authorization capability rather than explicit Authorization headers.

@digitarald
Copy link
Contributor

Thanks for contributing more realistic docs.

I agree with Connor's point, to not showcase auth via keys; and we should even call it out for this line as best practice.

@ntrogh
Copy link
Contributor

ntrogh commented Jun 3, 2025

@julien-closing this PR, given the above feedback. I'll update the docs to include additional guidance about authorization.

@ntrogh ntrogh closed this Jun 3, 2025
@julien-c
Copy link
Author

julien-c commented Jun 3, 2025

that works, thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants