Fix throwing out of catch #252126
Merged
Fix throwing out of catch #252126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
approved these changes
Jun 23, 2025
| @@ -899,10 +900,9 @@ export class ChatService extends Disposable implements IChatService { | |||
| numCodeBlocks: 0, | |||
| enableCommandDetection, | |||
| isParticipantDetected: !!detectedAgent, | |||
| attachmentKinds: this.attachmentKindsForTelemetry(request.variableData), | |||
| attachmentKinds: request ? this.attachmentKindsForTelemetry(request.variableData) : [], | |||
There was a problem hiding this comment.
Shouldn’t we fix the type so we don’t run into this again
Types indicate it’s not billable
There was a problem hiding this comment.
Approving as it’s not a blocker, but feel it should be fixed, as someone else could run into this again
There was a problem hiding this comment.
Yes, this code is a bit all over the place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of microsoft/vscode-copilot-release#9802