add sync.Pool for compression writers. #7056
Conversation
|
Thanks for the PR, but I am not yet convinced that this is characteristic of what's going on in #7037 and this may also cause us to hold onto and reuse much larger buffers than would be needed for a future connection. The per-client compressors are already reusing underlying buffers for the lifetime of a connection and I don't really think that it's creating the compressors that is the bulk of the issue, but rather that the latency sensitivity is too sensitive to GC pauses. Have you done comparative benchmarking for this? |
| @@ -1631,8 +1632,9 @@ func (c *client) flushOutbound() bool { | |||
| } | |||
| } | |||
| if err == nil { | |||
| err = cw.Close() | |||
| err = c.out.cf(cw) | |||
There was a problem hiding this comment.
In addition to @neilalexander comments, this is wrong and would break things. The writer is reused already (hence the Reset() above). That call would invalidate it causing likely memory corruptions.
|
@neilalexander you are right. |
Should greatly reduce CPU and memory when using compression.
should help resolve:
#7037
Signed-off-by: Aryeh Klein aryehlevklein@gmail.com