Process should not exit when pressing `ctrl + c` under `node --run`

[zanminkian]

Version

24.1.0

Platform

Linux colima 6.8.0-50-generic #51-Ubuntu SMP PREEMPT_DYNAMIC Sat Nov  9 18:03:35 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

Reproduce steps:

1. create package.json: {"scripts":{"x":"node x.js"}}
2. create x.js:

setTimeout(() => {
  process.exit(0);
}, 10_000);

process.addListener('SIGINT', () => {
  console.log('SIGINT');
});

process.addListener('SIGTERM', () => {
  console.log('SIGTERM');
});

3. run node --run x
4. press ctrl+c to kill it.

How often does it reproduce? Is there a required condition?

Every time.

What is the expected behavior? Why is that the expected behavior?

It should not be killed. Just like the behavior of running npm run x.

What do you see instead?

The process is killed.

Additional information

This behavior seems unsafe for backend app using Node.js, because backend app started by node --run will do cleaning once it receives SIGINT or SIGTERM from docker container. Docker container may stop immediately because node --run has already exited.

[bnoordhuis]

It should not be killed

It isn't killed, it's backgrounded. That's not a bug but traditional UNIX behavior (and not under node's influence, so it doesn't matter whether you like it or not, it just is.)

There are two node processes in your demo: an outer node --run and an inner node x. The ^C is sent to both processes (it's sent to the process group) and that terminates node --run. It leaves the other process alive; at least, until the timer expires.

If --require <file> was changed so it runs before --run, then you could catch the signal in the outer process, like this: node --require ./catch-signals --run x - but if you want to ignore ^C anyway, just disable it with stty intr ^-.

I'm going to close this but if you want to send a PR with that --require change, feel free.