vm: expose import phase on SourceTextModule.moduleRequests #58829

legendecas · 2025-06-25T10:47:56Z

Expose import phase on vm.SourceTextModule.moduleRequests. This deprecates vm.SourceTextModule.dependencySpecifiers as it does not expose import attributes nor import phase.

Refs: #37648

nodejs-github-bot · 2025-06-25T10:48:02Z

Review requested:

@nodejs/loaders
@nodejs/vm

codecov · 2025-06-25T11:57:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (100c6da) to head (f363954).
Report is 136 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58829      +/-   ##
==========================================
- Coverage   90.10%   90.08%   -0.02%     
==========================================
  Files         640      640              
  Lines      188384   188479      +95     
  Branches    36932    36964      +32     
==========================================
+ Hits       169735   169791      +56     
- Misses      11356    11402      +46     
+ Partials     7293     7286       -7

Files with missing lines	Coverage Δ
lib/internal/vm/module.js	`98.39% <100.00%> (+0.08%)`	⬆️
src/module_wrap.cc	`72.75% <100.00%> (+0.15%)`	⬆️

... and 50 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

joyeecheung

Thanks for working on this!

doc/api/vm.md

lib/internal/vm/module.js

nodejs-github-bot · 2025-06-27T13:05:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67680/

nodejs-github-bot · 2025-06-28T10:25:52Z

Commit Queue failed

node:internal/modules/esm/resolve:275 throw new ERR_MODULE_NOT_FOUND( ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/css-what/dist/esm/index.js' imported from /opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/cheerio-select/lib/esm/index.js
at finalizeResolution (node:internal/modules/esm/resolve:275:11)
at moduleResolve (node:internal/modules/esm/resolve:860:10)
at defaultResolve (node:internal/modules/esm/resolve:984:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:780:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:704:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:687:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:305:38)
at ModuleJob._link (node:internal/modules/esm/module_job:137:49) {
code: 'ERR_MODULE_NOT_FOUND',
url: 'file:///opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/css-what/dist/esm/index.js'
}

Node.js v22.16.0

https://github.com/nodejs/node/actions/runs/15943184073

marco-ippolito · 2025-06-28T10:32:30Z

Commit Queue failed

node:internal/modules/esm/resolve:275 throw new ERR_MODULE_NOT_FOUND( ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/css-what/dist/esm/index.js' imported from /opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/cheerio-select/lib/esm/index.js
at finalizeResolution (node:internal/modules/esm/resolve:275:11)
at moduleResolve (node:internal/modules/esm/resolve:860:10)
at defaultResolve (node:internal/modules/esm/resolve:984:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:780:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:704:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:687:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:305:38)
at ModuleJob._link (node:internal/modules/esm/module_job:137:49) {
code: 'ERR_MODULE_NOT_FOUND',
url: 'file:///opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/css-what/dist/esm/index.js'
}

Node.js v22.16.0

https://github.com/nodejs/node/actions/runs/15943184073

Is commit queue broken 💀

nodejs-github-bot · 2025-06-28T10:47:52Z

Commit Queue failed

node:internal/modules/esm/resolve:275 throw new ERR_MODULE_NOT_FOUND( ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/css-what/dist/esm/index.js' imported from /opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/cheerio-select/lib/esm/index.js
at finalizeResolution (node:internal/modules/esm/resolve:275:11)
at moduleResolve (node:internal/modules/esm/resolve:860:10)
at defaultResolve (node:internal/modules/esm/resolve:984:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:780:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:704:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:687:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:305:38)
at ModuleJob._link (node:internal/modules/esm/module_job:137:49) {
code: 'ERR_MODULE_NOT_FOUND',
url: 'file:///opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/css-what/dist/esm/index.js'
}

Node.js v22.16.0

https://github.com/nodejs/node/actions/runs/15943356431

nodejs-github-bot · 2025-06-28T14:15:32Z

Commit Queue failed

node:internal/process/promises:394 triggerUncaughtException(err, true /* fromPromise */); ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/css-select/lib/esm/index.js' imported from /opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/cheerio-select/lib/esm/index.js
Did you mean to import "css-select/lib/index.js"?
at finalizeResolution (node:internal/modules/esm/resolve:275:11)
at moduleResolve (node:internal/modules/esm/resolve:860:10)
at defaultResolve (node:internal/modules/esm/resolve:984:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:780:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:704:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:687:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:305:38)
at ModuleJob._link (node:internal/modules/esm/module_job:137:49) {
code: 'ERR_MODULE_NOT_FOUND',
url: 'file:///opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/css-select/lib/esm/index.js'
}

Node.js v22.16.0

https://github.com/nodejs/node/actions/runs/15945000951

nodejs-github-bot · 2025-06-28T18:51:50Z

Landed in 0f7e75f

PR-URL: #58829 Refs: #37648 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

aduh95 · 2025-07-21T17:36:29Z

Trying to backport this to v22.x-staging causes out/Release/node test/parallel/test-vm-module-modulerequests.js to crash with node: bad option: --js-source-phase-imports. Feel free to mark it as dont-land if it's an unsolvable V8 version mismatch

legendecas added the vm label Jun 25, 2025

nodejs-github-bot added c++ needs-ci labels Jun 25, 2025

legendecas force-pushed the vm-modulerequests branch from 7ce592e to 7f1891d Compare June 25, 2025 11:06

joyeecheung approved these changes Jun 27, 2025

View reviewed changes

doc/api/vm.md Show resolved Hide resolved

lib/internal/vm/module.js Outdated Show resolved Hide resolved

legendecas added request-ci and removed request-ci labels Jun 27, 2025

vm: expose import phase on SourceTextModule.moduleRequests

f363954

legendecas force-pushed the vm-modulerequests branch from 7f1891d to f363954 Compare June 27, 2025 13:05

marco-ippolito approved these changes Jun 27, 2025

View reviewed changes

joyeecheung approved these changes Jun 27, 2025

View reviewed changes

legendecas added the commit-queue label Jun 28, 2025

nodejs-github-bot added commit-queue-failed and removed commit-queue labels Jun 28, 2025

marco-ippolito added commit-queue and removed commit-queue-failed labels Jun 28, 2025

nodejs-github-bot added commit-queue-failed and removed commit-queue labels Jun 28, 2025

legendecas added commit-queue and removed commit-queue-failed labels Jun 28, 2025

nodejs-github-bot added commit-queue-failed and removed commit-queue labels Jun 28, 2025

aduh95 added the author ready label Jun 28, 2025

aduh95 added commit-queue and removed commit-queue-failed labels Jun 28, 2025

nodejs-github-bot removed the commit-queue label Jun 28, 2025

nodejs-github-bot merged commit 0f7e75f into nodejs:main Jun 28, 2025
84 checks passed

legendecas deleted the vm-modulerequests branch June 28, 2025 18:57

targos pushed a commit that referenced this pull request Jul 3, 2025

vm: expose import phase on SourceTextModule.moduleRequests

a1f4333

PR-URL: #58829 Refs: #37648 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

github-actions bot mentioned this pull request Jul 8, 2025

2025-07-09, Version 24.4.0 (Current) #58993

Merged

aduh95 added the backport-requested-v22.x label Jul 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

vm: expose import phase on SourceTextModule.moduleRequests #58829

vm: expose import phase on SourceTextModule.moduleRequests #58829

legendecas commented Jun 25, 2025

Uh oh!

nodejs-github-bot commented Jun 25, 2025

Uh oh!

codecov bot commented Jun 25, 2025 •

edited

Loading

Uh oh!

joyeecheung left a comment

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 27, 2025

Uh oh!

nodejs-github-bot commented Jun 28, 2025

Uh oh!

marco-ippolito commented Jun 28, 2025

Uh oh!

nodejs-github-bot commented Jun 28, 2025

Uh oh!

nodejs-github-bot commented Jun 28, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 28, 2025

Uh oh!

aduh95 commented Jul 21, 2025

Uh oh!

Uh oh!

Uh oh!

vm: expose import phase on SourceTextModule.moduleRequests #58829

vm: expose import phase on SourceTextModule.moduleRequests #58829

Conversation

legendecas commented Jun 25, 2025

Uh oh!

nodejs-github-bot commented Jun 25, 2025

Uh oh!

codecov bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joyeecheung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 27, 2025

Uh oh!

nodejs-github-bot commented Jun 28, 2025

Uh oh!

marco-ippolito commented Jun 28, 2025

Uh oh!

nodejs-github-bot commented Jun 28, 2025

Uh oh!

nodejs-github-bot commented Jun 28, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 28, 2025

Uh oh!

aduh95 commented Jul 21, 2025

Uh oh!

Uh oh!

codecov bot commented Jun 25, 2025 •

edited

Loading