Fix accelerator device map #1913

vimalk78 · 2025-01-21T19:59:50Z

brings back .dockerignore file
fix the logic of adding accelerator device map
added few log statements

Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>

…server-patch-1 feat: add model_name attribute to ComponentModelWeights

Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>

Signed-off-by: Sunil Thaha <sthaha@redhat.com>

…r-longer-test chore(validator): run stress test for longer

This commit introduces a workflow for testing ACPI functionality using Equinix self-hosted runners. The workflow deploys Kepler using mock-acpi compose setup and runs validator to ensure functionality. Key-features: - Workflow is triggered on pull requests that include a specific commit message `/test-acpi`. - Environment setup is handled by ansible. Signed-off-by: Vibhu Prashar <vibhu.sharma2929@gmail.com>

…puting-io/add-acpi-wkf feat(ci): implement mock-ACPI workflow

…server-patch-1 fix: format ComponentModelWeights

This commit moves model_weights from/var/lib/kepler/data/ to its own directory - var/lib/kepler/data/model_weights/ this allows additional data like machine-spec to be stored its own directory. Additionally this change fixes the blank cpu.yaml that gets created when running compose files. Signed-off-by: Sunil Thaha <sthaha@redhat.com>

…k-cpu-yaml chore: move model_weights to its own directory

Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>

This commit resolves two key issues with the mock-acpi workflow: - Checkout correct branch: The workflow previously checkout out the default branch when triggered by a pull request. This fix ensures that the correct pull request branch is checked out during CI run. - Attach workflow to pull request checks: The workflow was not being reflected under pull request checks. With this fix, the workflow will be correctly attached, ensuring its status visible and reported under pull request checks. Signed-off-by: Vibhu Prashar <vibhu.sharma2929@gmail.com>

…eanup-exporter-globals chore: cleanup globals in exporter

Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>

…server-patch-1 fix: set default trainer only for local regressor

…pi-wk-status fix(ci): ensure proper status reporting for mock-acpi workflow

This commit addresses an issue where the `cleanup` and `final status` jobs were incorrectly dependent on the `create-runner` job, leading to their premature execution. This fix ensures that both `cleanup` and `final status` job run independently and only after all necessary preceding jobs have finished Signed-off-by: Vibhu Prashar <vibhu.sharma2929@gmail.com>

Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>

…server-patch-1 feat: add --disable-power-meter option

…x-job-flow fix(ci): ensure independent execution of cleanup and status jobs

…idation feat: Export validation result as json object.

Signed-off-by: Vimal Kumar <vimal78@gmail.com>

Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>

This commit addresses the issue of multiple jobs defined in the `mock-acpi` workflow, which were unintentionally executing in parallel due to sequence constraints. By consolidating the workflow into a single job, we ensure that the tasks are executed sequentially Signed-off-by: Vibhu Prashar <vibhu.sharma2929@gmail.com>

…puting-io/fix-flow fix(ci): consolidate mock-acpi workflow into single job

Updates: * kepler_model_server to 0.7.11-2. * Models to 0.7.11 SGDRegressor * Adds DISABLE_POWER_METER env to disable power meters when running vm compose on a BM (just in case) Signed-off-by: Sunil Thaha <sthaha@redhat.com>

…ms-0.7.11-2 chore(compose): bumpup model-server to v0.7.11-2

Add cosign to two additional image building workflows to resolve intermittent signing issue. Uses GitHub OIDC token for signing, and narrows scope of privileges to only what is necessary to write token. Signed-off-by: Arthur Savage <arthursavage47@gmail.com>

Signed-off-by: Vimal Kumar <vimal78@gmail.com>

This commit migrates the mock-acpi workflow to use the GitHub runner instead of the Equinix self-hosted runner. Since the workflow is designed for testing ACPI functionality, using a mock, a self-hosted runner is not required. Running the workflow on the GitHub runner, which operates as a VM, enables execution on every pull request, ensuring consistent validation of ACPI functionality for Kepler. Signed-off-by: vprashar2929 <vibhu.sharma2929@gmail.com>

…pi-wkf chore(ci): migrate mock-acpi workflow to GH runner

* [test]: add test case on package cgroup Signed-off-by: Sam Yuan <yy19902439@126.com> * [fix]: update cache setting logic when error happen Signed-off-by: Sam Yuan <yy19902439@126.com> * [fix]: fix lint Signed-off-by: Sam Yuan <yy19902439@126.com> --------- Signed-off-by: Sam Yuan <yy19902439@126.com>

…om-scaph feat(compose): add fallback scrape protocol for Scaphandre service

Signed-off-by: Huamin Chen <hchen@redhat.com>

Signed-off-by: Sam Yuan <yy19902439@126.com>

Signed-off-by: Mario Vazquez <mavazque@redhat.com>

…e-paths Fixes paths for grace arm

Signed-off-by: Huamin Chen <hchen@redhat.com>

…race feat(sensor): support NVIDIA Grace Hopper

…e-computing-io#1889) Bumps the github-actions group with 4 updates: [actions/checkout](https://github.com/actions/checkout), [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance), [actions/attest-sbom](https://github.com/actions/attest-sbom) and [codecov/codecov-action](https://github.com/codecov/codecov-action). Updates `actions/checkout` from 3 to 4 - [Release notes](https://github.com/actions/checkout/releases) - [Commits](actions/checkout@v3...v4) Updates `actions/attest-build-provenance` from 1 to 2 - [Release notes](https://github.com/actions/attest-build-provenance/releases) - [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md) - [Commits](actions/attest-build-provenance@v1...v2) Updates `actions/attest-sbom` from 1 to 2 - [Release notes](https://github.com/actions/attest-sbom/releases) - [Changelog](https://github.com/actions/attest-sbom/blob/main/RELEASE.md) - [Commits](actions/attest-sbom@v1...v2) Updates `codecov/codecov-action` from 5.0.7 to 5.1.1 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v5.0.7...v5.1.1) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/attest-build-provenance dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/attest-sbom dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ble-computing-io#1892) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.26.0 to 0.31.0. - [Commits](golang/crypto@v0.26.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Sam Yuan <yy19902439@126.com>

…stainable-computing-io#1896) Bumps the github-actions group with 1 update: [anchore/sbom-action](https://github.com/anchore/sbom-action). Updates `anchore/sbom-action` from 0.17.8 to 0.17.9 - [Release notes](https://github.com/anchore/sbom-action/releases) - [Changelog](https://github.com/anchore/sbom-action/blob/main/RELEASE.md) - [Commits](anchore/sbom-action@v0.17.8...v0.17.9) --- updated-dependencies: - dependency-name: anchore/sbom-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…e-computing-io#1900) Bumps the github-actions group with 2 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact) and [codecov/codecov-action](https://github.com/codecov/codecov-action). Updates `actions/upload-artifact` from 4.4.3 to 4.5.0 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4.4.3...v4.5.0) Updates `codecov/codecov-action` from 5.1.1 to 5.1.2 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

github-actions · 2025-01-21T20:00:42Z

🤖 SeineSailor

Here is a concise summary of the pull request changes:

Summary: The "Fix accelerator device map" pull request refactors the accelerator device map logic, improving internal diagnostics and adding log statements for better visibility. Key modifications include corrections to device map addition logic and the introduction of the GetAllDevices() method to the Registry type.

Impact: These changes enhance the code's internal functionality without affecting the external interface or behavior, except for the added GetAllDevices() method. The readded .dockerignore file ensures proper Docker container setup.

Observations: The changes are focused on internal improvements, suggesting a refinement of the existing implementation rather than a significant architectural shift. The addition of log statements and diagnostics will aid in debugging and troubleshooting.

Suggestions: Consider adding tests to validate the corrected device map logic and the new GetAllDevices() method to ensure their correctness and reliability.

rootfs · 2025-01-22T00:54:20Z

can you sign DCO?

…sustainable-computing-io#1809)" This reverts commit 91c8e62. Signed-off-by: Vimal Kumar <vimal78@gmail.com>

Signed-off-by: Vimal Kumar <vimal78@gmail.com>

vimalk78 · 2025-01-23T06:36:42Z

can you sign DCO?

@rootfs signed DCO

vprashar2929 · 2025-01-30T05:48:18Z

.dockerignore

Adding .dockerignore will lead to incorrect version computation #1809

sthaha · 2025-02-02T23:40:37Z

pkg/sensors/accelerator/devices/dcgm.go

 	if err != nil {
 		klog.Infof("There is no DCGM daemon running in the host: %s", err)
 		// embedded mode is not recommended for production per https://github.com/NVIDIA/dcgm-exporter/issues/22#issuecomment-1321521995
+		klog.Info("Attempting to inilialize dcgm in Embedded mode.")


nit typo: initialize

sthaha · 2025-03-07T22:27:55Z

pkg/sensors/accelerator/accelerator.go

+	j, _ := json.Marshal(r.GetAllDevices())
+	klog.V(5).Infof("Accelerator Registry AllDevices: %s", string(j))


how about we marshal only if klog.V(5).IsEnabled() ?

sthaha · 2025-03-07T22:30:24Z

pkg/sensors/accelerator/devices/device.go

+	} else {
+		m[d] = deviceStartup


shouldn't we panic here instead? The accelerator has ready been defined and there is now an attempt to overwrite it. IMHO, we should panic and aligns with the Must in MustRegister.

sunya-ch and others added 30 commits August 16, 2024 10:25

feat: add model_name attribute to ComponentModelWeights

a6f75a4

Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>

Merge pull request sustainable-computing-io#1699 from sunya-ch/model-…

7639d50

…server-patch-1 feat: add model_name attribute to ComponentModelWeights

fix: format ComponentModelWeights

d446231

Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>

chore(validator): run stress test for longer

f6762ba

Signed-off-by: Sunil Thaha <sthaha@redhat.com>

Merge pull request sustainable-computing-io#1703 from sthaha/validato…

21c7b26

…r-longer-test chore(validator): run stress test for longer

Merge pull request sustainable-computing-io#1705 from sustainable-com…

a388f0a

…puting-io/add-acpi-wkf feat(ci): implement mock-ACPI workflow

Merge pull request sustainable-computing-io#1701 from sunya-ch/model-…

6512444

…server-patch-1 fix: format ComponentModelWeights

Merge pull request sustainable-computing-io#1708 from sthaha/fix-blan…

73feea9

…k-cpu-yaml chore: move model_weights to its own directory

chore: cleanup globals in exporter

d8168cc

Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>

Merge pull request sustainable-computing-io#1710 from maryamtahhan/cl…

d143b67

…eanup-exporter-globals chore: cleanup globals in exporter

fix: set default trainer only for local regressor

414533c

Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>

Merge pull request sustainable-computing-io#1715 from sunya-ch/model-…

1f14180

…server-patch-1 fix: set default trainer only for local regressor

Merge pull request sustainable-computing-io#1712 from vprashar2929/ac…

821afc5

…pi-wk-status fix(ci): ensure proper status reporting for mock-acpi workflow

feat: add --disable-power-meter option

11ff51d

Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>

Merge pull request sustainable-computing-io#1717 from sunya-ch/model-…

9fc7c7c

…server-patch-1 feat: add --disable-power-meter option

Merge pull request sustainable-computing-io#1716 from vprashar2929/fi…

8421eea

…x-job-flow fix(ci): ensure independent execution of cleanup and status jobs

Merge pull request sustainable-computing-io#1631 from husky-parul/val…

c56c2fc

…idation feat: Export validation result as json object.

feat(compose): sampling vs probing (sustainable-computing-io#1719)

ffa5ab6

Signed-off-by: Vimal Kumar <vimal78@gmail.com>

chore(git): add a .dockerignore file (sustainable-computing-io#1720)

d16be0d

Signed-off-by: Vimal Kumar <vimal78@gmail.com>

docs: add Exporter overview (sustainable-computing-io#1636)

cefe652

Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>

Merge pull request sustainable-computing-io#1722 from sustainable-com…

0f3651b

…puting-io/fix-flow fix(ci): consolidate mock-acpi workflow into single job

chore(compose): bumpup model-server to v0.7.11-2

2dcd788

Updates: * kepler_model_server to 0.7.11-2. * Models to 0.7.11 SGDRegressor * Adds DISABLE_POWER_METER env to disable power meters when running vm compose on a BM (just in case) Signed-off-by: Sunil Thaha <sthaha@redhat.com>

Merge pull request sustainable-computing-io#1725 from sthaha/update-k…

c106b46

…ms-0.7.11-2 chore(compose): bumpup model-server to v0.7.11-2

fix(compose): remove unwanted dependency on kepler-latest

e4d7e08

Signed-off-by: Vimal Kumar <vimal78@gmail.com>

vprashar2929 and others added 15 commits December 5, 2024 10:17

Merge pull request sustainable-computing-io#1882 from vprashar2929/ac…

8ab7ff8

…pi-wkf chore(ci): migrate mock-acpi workflow to GH runner

Merge pull request sustainable-computing-io#1870 from vprashar2929/pr…

33c5c73

…om-scaph feat(compose): add fallback scrape protocol for Scaphandre service

feat(sensor): support NVIDIA Grace Hopper

cf469c2

Signed-off-by: Huamin Chen <hchen@redhat.com>

[fix]: try to reduce escapes to heap (sustainable-computing-io#1886)

c9524a8

Signed-off-by: Sam Yuan <yy19902439@126.com>

Fixes paths for grace arm

c9c2aba

Signed-off-by: Mario Vazquez <mavazque@redhat.com>

Merge pull request sustainable-computing-io#4 from mvazquezc/fix-grac…

b270d64

…e-paths Fixes paths for grace arm

chore(sensor): fix lint

b9e42b8

Signed-off-by: Huamin Chen <hchen@redhat.com>

Merge pull request sustainable-computing-io#1884 from rootfs/nvidia-g…

20979b2

…race feat(sensor): support NVIDIA Grace Hopper

[fix]: enhance kubelet package impl (sustainable-computing-io#1894)

98275d0

Signed-off-by: Sam Yuan <yy19902439@126.com>

vimalk78 requested a review from rootfs January 21, 2025 20:00

vimalk78 force-pushed the fix-accel-map branch from 33fdffa to 40b36a1 Compare January 21, 2025 20:03

vimalk78 added 2 commits January 22, 2025 11:34

Revert "fix: remove .dockerignore to ensure clean version computation (…

2c66e21

…sustainable-computing-io#1809)" This reverts commit 91c8e62. Signed-off-by: Vimal Kumar <vimal78@gmail.com>

fix(gpu): fix accelerator registry map

9ca44bf

Signed-off-by: Vimal Kumar <vimal78@gmail.com>

vimalk78 force-pushed the fix-accel-map branch from 40b36a1 to 9ca44bf Compare January 22, 2025 06:05

vprashar2929 reviewed Jan 30, 2025

View reviewed changes

.dockerignore

Copy link

Collaborator

vprashar2929 Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding .dockerignore will lead to incorrect version computation #1809

sthaha reviewed Feb 2, 2025

View reviewed changes

rootfs approved these changes Feb 4, 2025

View reviewed changes

sthaha reviewed Mar 7, 2025

View reviewed changes

sthaha closed this Jul 9, 2025

sthaha force-pushed the main branch from e6aceef to f7243fd Compare July 9, 2025 07:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix accelerator device map #1913

Fix accelerator device map #1913

Uh oh!

vimalk78 commented Jan 21, 2025

Uh oh!

github-actions bot commented Jan 21, 2025 •

edited

Loading

Uh oh!

rootfs commented Jan 22, 2025

Uh oh!

vimalk78 commented Jan 23, 2025

Uh oh!

vprashar2929 Jan 30, 2025

Uh oh!

sthaha Feb 2, 2025

Uh oh!

sthaha Mar 7, 2025

Uh oh!

sthaha Mar 7, 2025

Uh oh!

Uh oh!

		j, _ := json.Marshal(r.GetAllDevices())
		klog.V(5).Infof("Accelerator Registry AllDevices: %s", string(j))

Fix accelerator device map #1913

Fix accelerator device map #1913

Uh oh!

Conversation

vimalk78 commented Jan 21, 2025

Uh oh!

github-actions bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rootfs commented Jan 22, 2025

Uh oh!

vimalk78 commented Jan 23, 2025

Uh oh!

vprashar2929 Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

sthaha Feb 2, 2025

Choose a reason for hiding this comment

Uh oh!

sthaha Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

sthaha Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jan 21, 2025 •

edited

Loading