Skip to content

Missing element modifier prose-picture #366

Open
@tordans

Description

@tordans
Contributor

What version of @tailwindcss/typography are you using?

"@tailwindcss/typography": "^0.5.15",

What version of Node.js are you using?

lts/*

What browser are you using?

Chrome

What operating system are you using?

MacOS

Reproduction repository

Describe your issue

The PR #314 (Issue #144) added default styles to the <picture> but there are is no element modifier defined that would allow us to easily change the default styles via classes

I suggest to add two modfiers

  • prose-picture:* targeting <picture>
  • prose-images:* targeting <img> <picture>

Another question that this brings up is, if the prose-img modifier should target the picture>img element as well. It does ATM https://play.tailwindcss.com/VFWabWBye5 so changing this is likely a breaking change and something to be resolved separately?

Activity

changed the title [-]Missing overwrite `prose-picture`[/-] [+]Missing element modifier `prose-picture`[/+] on Dec 5, 2024
tordans

tordans commented on Dec 5, 2024

@tordans
ContributorAuthor

Also, just in case someone comes here after using Astros <Picture> Element, there is an easy overwrite:

      <Picture
        src={image}
        formats={['png', 'avif']}
        class="rounded" // classes on the <img> tag
        pictureAttributes={{ class: 'not-prose' }} // classes on the <picture> tag
        alt=""
      />
added a commit that references this issue on Jan 9, 2025
3223d89
linked a pull request that will close this issue on Jan 9, 2025
bmiit145

bmiit145 commented on Jan 9, 2025

@bmiit145

I have added wait for approval from maintainer

abdobouna

abdobouna commented on May 18, 2025

@abdobouna

Also, support is missing for the definition list <dl>.

piotrkulpinski

piotrkulpinski commented on May 19, 2025

@piotrkulpinski
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @tordans@piotrkulpinski@abdobouna@bmiit145

      Issue actions

        Missing element modifier `prose-picture` · Issue #366 · tailwindlabs/tailwindcss-typography