Skip to content

Add tests for #daptOriginTimecode #4

@nigelmegitt

Description

@nigelmegitt
Contributor

Add tests relating to DAPT §G.4 #daptOriginTimecode

Activity

nigelmegitt

nigelmegitt commented on Apr 24, 2025

@nigelmegitt
ContributorAuthor

Valid test resources:

  • Have a <daptm:daptOriginTimecode> element present at the path /tt/head/metadata/daptm:daptOriginTimecode whose content conforms to a clock-time with a frames component, as defined in <time-expression> AND
  • have a ttp:frameRate attribute on the root <tt> element with a valid value as per TTML2 (as per 5.7.3 ttp:frameRate)

Expect >=1 valid test resource.

Invalid test resources:

  • Have two or more <daptm:daptOriginTimecode> elements present at the path /tt/head/metadata/daptm:daptOriginTimecode OR
  • Have a <daptm:daptOriginTimecode> element present at the path /tt/head/metadata/daptm:daptOriginTimecode with content that does not conform to a clock-time with a frames component, as defined in <time-expression> OR
  • Have a <daptm:daptOriginTimecode> element present at the path /tt/head/metadata/daptm:daptOriginTimecode whose content conforms to a clock-time with a frames component, as defined in <time-expression> BUT has no ttp:frameRate attribute on the root <tt> element OR
  • Have a <daptm:daptOriginTimecode> element present at the path /tt/head/metadata/daptm:daptOriginTimecode whose content conforms to a clock-time with a frames component, as defined in <time-expression> and has a ttp:frameRate attribute on the root <tt> element BUT the frame component value >= the number of frames per second.

Expect >= 4 invalid test resources.

Presentation semantics

There are no presentation semantics associated with this feature.

cconcolato

cconcolato commented on Jun 9, 2025

@cconcolato
Contributor

Have two or more daptm:daptOriginTimecode elements present at the path /tt/head/metadata/daptm:daptOriginTimecode

Not sure we need to test that as this is basic XML rule.

cconcolato

cconcolato commented on Jun 9, 2025

@cconcolato
Contributor

Should we have an invalid test when the attribute is present on a metadata element somewhere else, like body?

nigelmegitt

nigelmegitt commented on Jun 10, 2025

@nigelmegitt
ContributorAuthor

Have two or more daptm:daptOriginTimecode elements present at the path /tt/head/metadata/daptm:daptOriginTimecode

Not sure we need to test that as this is basic XML rule.

I don't think it is, remember this is an element not an attribute.

nigelmegitt

nigelmegitt commented on Jun 10, 2025

@nigelmegitt
ContributorAuthor

Should we have an invalid test when the attribute is present on a metadata element somewhere else, like body?

(it's an element not an attribute)

It's not prohibited elsewhere, so it wouldn't be an invalid test, just a meaningless one.

added
Ready for PRThe issue has reached consensus for a pull request to be prepared and opened.
on Jun 12, 2025
added a commit that references this issue on Jun 13, 2025
394bffc
added
PR OpenA pull request is open to resolve this issue
and removed
Ready for PRThe issue has reached consensus for a pull request to be prepared and opened.
on Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    PR OpenA pull request is open to resolve this issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @cconcolato@nigelmegitt

      Issue actions

        Add tests for `#daptOriginTimecode` · Issue #4 · w3c/dapt-tests