Skip to content

Add WPT metadata to spec #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add WPT metadata to spec #282

wants to merge 2 commits into from

Conversation

TimvdLippe
Copy link

No description provided.

Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w3cbot
Copy link

w3cbot commented Jun 11, 2025

yoavweiss marked as non substantive for IPR from ash-nazg.

@yoavweiss
Copy link
Contributor

Hmm, this seems to get bikeshed failures:

    $ bikeshed --die-on=warning spec "index.bs" "index.bs.built.html" 
      WARNING: There are 22 WPT tests underneath your path prefix '/reporting/' that aren't in your document and must be added. (Use a <wpt hidden> if you don't actually want them in your document.)
        reporting/bufferSize.html
        reporting/cross-origin-report-no-credentials.https.sub.html
        reporting/cross-origin-reports-isolated.https.sub.html
        reporting/cross-origin-same-site-credentials.https.sub.html
        reporting/disconnect.html
        reporting/document-reporting-bypass-report-to.https.sub.html
        reporting/document-reporting-default-endpoint.https.sub.html
        reporting/document-reporting-destroy-after-document-close.https.sub.html
        reporting/document-reporting-named-endpoints.https.sub.html
        reporting/document-reporting-not-batch-different-document.https.html
        reporting/document-reporting-override-endpoint.https.sub.html
        reporting/document-reporting-path-absolute.https.sub.html
        reporting/generateTestReport-honors-endpoint.https.sub.html
        reporting/generateTestReport.html
        reporting/idlharness.any.js
        reporting/nestedReport.html
        reporting/order.html
        reporting/reporting-api-honors-limits.https.sub.html
        reporting/reporting-isolated-across-navigations.https.sub.html
        reporting/same-origin-cross-site-credentials.https.sub.html
        reporting/same-origin-report-credentials.https.sub.html
        reporting/same-origin-same-site-credentials.https.sub.html
       ✘  Did not generate, due to errors exceeding the allowed error level.
    Command `bikeshed --die-on=warning spec "index.bs" "index.bs.built.html" ` failed with exit code: 2.
    ```

@TimvdLippe
Copy link
Author

Apparently ths tests need to be explicitly listed in the documented. I copied that approach from Trusted Types: https://github.com/w3c/trusted-types/blob/279d0ddb1e96173bd3d471306ee22201b07469f3/spec/index.bs#L21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants