Rely on the IDL definitions for dictionary members. #304
Conversation
Before this change dictionaries and their members were defined in IDL blocks, then the members were redefined using `<dfn>` elements inside `<dl>`. After this change the `<dfn>` and `<dl>`'s are removed; instead the IDL definitions of the members are referenced. Additionally, this change reuses the styles for the domintro class from the WHATWG styles. Notably, this adds "For web developers (non-normative)" as a heading to each domintro block. See issue w3c#302.
|
(This is not my speciality so I defer.) |
|
Just to check, this is not currently marked as having any reviewers - @pejic , were you looking for it to be reviewed? |
There was a check failure that I was going to find the time to resolve; however, the checks do pass now: So review can begin. I will add you, Stephen, to review. |
spec.bs
Outdated
| :: Indicates that the extension is active. | ||
|
|
||
| : <dfn>rpId</dfn> member | ||
| : {{AuthenticationExtensionsPaymentInputs/rpId}} | ||
| :: The [=Relying Party=] id of the credential(s) being used. Only used at authentication time; not registration. |
There was a problem hiding this comment.
If this is now for web developers specifically, it should say "Only used at authentication time, not registration, and should not be set directly by web developers." or similar, here and below.
There was a problem hiding this comment.
Done. browserBoundPubKeyCredParams can be set on registration so the description is slightly different for that field.
Addressing stephenmcgruer's feedback on w3c#304 * Add steps for checking well-formed language tags are in SecurePaymentConfirmationRequest/locale. * Adjusting the language inside domintro to the target audience, web developers.
Addressing stephenmcgruer's feedback on w3c#304 * Add steps for checking well-formed language tags are in SecurePaymentConfirmationRequest/locale. * Adjusting the language inside domintro to the target audience, web developers.
Addressing stephenmcgruer's feedback on w3c#304 * Add steps for checking well-formed language tags are in SecurePaymentConfirmationRequest/locale. * Adjusting the language inside domintro to the target audience, web developers.
spec.bs
Outdated
| :: Indicates that the extension is active. | ||
|
|
||
| : <dfn>rpId</dfn> member | ||
| : {{AuthenticationExtensionsPaymentInputs/rpId}} | ||
| :: The [=Relying Party=] id of the credential(s) being used. Only used at authentication time; not registration. |
There was a problem hiding this comment.
Done. browserBoundPubKeyCredParams can be set on registration so the description is slightly different for that field.
Other PaymentCredentialInstrument members were moved into domintro and no longer double-defined. This occurred in a separate branch from the introduction of the details member. So after the merge commit this fix needs to be applied.
SHA: da7256d Reason: push, by stephenmcgruer Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: da7256d Reason: push, by stephenmcgruer Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Before this change dictionaries and their members were defined in IDL blocks, then the members were redefined using
<dfn>elements inside<dl>. After this change the<dfn>and<dl>'s are removed; instead the IDL definitions of the members are referenced.Additionally, this change reuses the styles for the domintro class from the WHATWG styles. Notably, this adds "For web developers (non-normative)" as a heading to each domintro block.
See issue #302.
Preview | Diff