Skip to content

feat: node disable streaming option #11947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 3, 2025
Merged

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Jun 24, 2025

Description (required)

Documents the upcoming experimentalDisableStreaming node adapter option

Related issues & labels (optional)

  • Closes #
  • Suggested label:

withastro/astro#14012

Copy link

netlify bot commented Jun 24, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 751ef1c
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6866615d7e2e6c00082f9575
😎 Deploy Preview https://deploy-preview-11947--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 24, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/integrations-guide/node.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great everyone! Thanks for working out all the details! 🙌

Florian, I've left one comment because while this explains what it does, I think we could be more helpful in explaining when you would (or importantly, would not!) want this!

@JusticeMatthew
Copy link
Contributor

Provided feedback on T&D

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on what was said during T&D, the new description looks better! LGTM! 🙌🏽

However, I unresolved my previous suggestion (the p tag), because it's not there, so the margin is wrong.

Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@florian-lefebvre
Copy link
Member Author

That's because I force pushed, thanks for flagging!

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarah11918 sarah11918 added this to the 5.11.0 milestone Jun 30, 2025
@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Jun 30, 2025
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Florian! Comment below!

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@sarah11918 sarah11918 added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Jul 1, 2025
@sarah11918 sarah11918 changed the base branch from main to 5.11.0 July 3, 2025 10:56
@sarah11918 sarah11918 merged commit ec71bd0 into 5.11.0 Jul 3, 2025
6 checks passed
@sarah11918 sarah11918 deleted the feat/node-disable-streaming branch July 3, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants