-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: node disable streaming option #11947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great everyone! Thanks for working out all the details! 🙌
Florian, I've left one comment because while this explains what it does, I think we could be more helpful in explaining when you would (or importantly, would not!) want this!
Provided feedback on T&D |
b4bfada
to
3679dec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on what was said during T&D, the new description looks better! LGTM! 🙌🏽
However, I unresolved my previous suggestion (the p
tag), because it's not there, so the margin is wrong.
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
That's because I force pushed, thanks for flagging! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Florian! Comment below!
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Description (required)
Documents the upcoming
experimentalDisableStreaming
node adapter optionRelated issues & labels (optional)
withastro/astro#14012