Skip to content

Add TPC-C to YDB CLI (#17333) #19978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

Conversation

eivanov89
Copy link
Member

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@eivanov89 eivanov89 requested a review from Copilot June 20, 2025 13:12
@eivanov89 eivanov89 requested a review from a team as a code owner June 20, 2025 13:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for the TPC-C benchmark in the YDB CLI by enabling the previously commented-out workload command and updating the changelog entry.

  • Uncommented the command to add TPC-C workload functionality.
  • Updated the CHANGELOG.md to document the addition of the new TPC-C benchmark.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
ydb/public/lib/ydb_cli/commands/ydb_workload.cpp Uncommented the TCommandTPCC addition to enable the TPC-C workload command.
ydb/apps/ydb/CHANGELOG.md Added an entry for the TPC-C benchmark in the changelog.

Copy link

github-actions bot commented Jun 20, 2025

2025-06-20 13:18:04 UTC Pre-commit check linux-x86_64-release-asan for 33df566 has started.
2025-06-20 13:18:15 UTC Artifacts will be uploaded here
2025-06-20 13:20:57 UTC ya make is running...
🟡 2025-06-20 14:32:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1361 1213 0 14 127 7

2025-06-20 14:33:00 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-20 14:55:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
248 (only retried tests) 130 0 12 100 6

2025-06-20 14:55:48 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-20 15:18:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
204 (only retried tests) 85 0 11 103 5

🟢 2025-06-20 15:18:12 UTC Build successful.
🔴 2025-06-20 15:18:30 UTC ydbd size 3.9 GiB changed* by +3.6 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 40c48d4 merge: 33df566 diff diff %
ydbd size 4 180 699 536 Bytes 4 184 443 080 Bytes +3.6 MiB +0.090%
ydbd stripped size 1 449 321 432 Bytes 1 450 449 752 Bytes +1.1 MiB +0.078%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

🟢 2025-06-20 13:18:54 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jun 20, 2025

2025-06-20 13:29:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 33df566 has started.
2025-06-20 13:29:26 UTC Artifacts will be uploaded here
2025-06-20 13:32:31 UTC ya make is running...
🟡 2025-06-20 14:18:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2139 2123 0 3 4 9

2025-06-20 14:18:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-20 14:29:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
63 (only retried tests) 54 0 1 1 7

2025-06-20 14:30:00 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-06-20 14:36:26 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 (only retried tests) 12 0 0 0 6

🟢 2025-06-20 14:36:35 UTC Build successful.
🔴 2025-06-20 14:36:47 UTC ydbd size 2.2 GiB changed* by +2.1 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 40c48d4 merge: 33df566 diff diff %
ydbd size 2 376 655 024 Bytes 2 378 884 112 Bytes +2.1 MiB +0.094%
ydbd stripped size 498 045 256 Bytes 498 383 368 Bytes +330.2 KiB +0.068%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@eivanov89 eivanov89 enabled auto-merge (squash) June 20, 2025 14:01
@eivanov89 eivanov89 merged commit 7c45832 into ydb-platform:main Jun 20, 2025
14 checks passed
@eivanov89 eivanov89 deleted the add_tpcc_to_cli branch July 7, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants