Add compaction logs #19990
Add compaction logs #19990
Conversation
|
⚪ |
|
⚪ |
|
🔴 The changelog entry is less than 20 characters or missing. |
VPolka
force-pushed
the
add-compaction-logs-2
branch
from
956338c to
06ab15e
Compare
VPolka
force-pushed
the
add-compaction-logs-2
branch
from
06ab15e to
0527738
Compare
VPolka
force-pushed
the
add-compaction-logs-2
branch
from
0527738 to
2f56013
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -100,7 +100,18 @@ namespace NKikimr { | |||
| bool allowGarbageCollection) | |||
| { | |||
| ui64 yardFreeUpToLsn = rtCtx->GetFreeUpToLsn(); | |||
| bool compact = hullDs->HullCtx->FreshCompaction && rtCtx->LevelIndex->NeedsFreshCompaction(yardFreeUpToLsn, force); | |||
| bool needsFreshCompaction = false; | |||
There was a problem hiding this comment.
compact and needsFreshCompaction always have the same value, maybe delete needsFreshCompaction?
| @@ -298,7 +298,7 @@ namespace NKikimr { | |||
| } | |||
|
|
|||
| TString ToString() const { | |||
| return Sprintf("[%u %p %s]", Level, SstPtr.Get(), SstPtr->FirstKey().ToString().data()); | |||
| return Sprintf("[%u %p (%s-%s)]", Level, SstPtr.Get(), SstPtr->FirstKey().ToString().data(), SstPtr->LastKey().ToString().data()); | |||
There was a problem hiding this comment.
SstPtr.Get() is a bad and unreliable way to name SST's. Maybe use SST's first lsn instead?
This will allow us to find an SSt in UI and it will remain consistent across process restarts.
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
VPolka
force-pushed
the
add-compaction-logs-2
branch
from
330a548 to
6fa8368
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
VPolka
force-pushed
the
add-compaction-logs-2
branch
from
6fa8368 to
9a2ae07
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
...