Skip to content

Switch to accessors, prepare to rename fields #19999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2025

Conversation

vitstn
Copy link
Collaborator

@vitstn vitstn commented Jun 20, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@vitstn vitstn requested review from a team as code owners June 20, 2025 21:28
@vitstn vitstn enabled auto-merge (squash) June 20, 2025 21:30
@vitstn vitstn changed the title Switch to accessors, prepare to renamed fields Switch to accessors, prepare to rename fields Jun 20, 2025
Copy link

github-actions bot commented Jun 20, 2025

🟢 2025-06-20 21:32:01 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jun 20, 2025

2025-06-20 21:32:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 50dab8b has started.
2025-06-20 21:32:29 UTC Artifacts will be uploaded here
2025-06-20 21:35:44 UTC ya make is running...
🟡 2025-06-20 22:45:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
36596 33889 0 1 2665 41

2025-06-20 22:49:02 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-20 23:00:16 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
597 (only retried tests) 568 0 0 0 29

🟢 2025-06-20 23:00:25 UTC Build successful.
🟢 2025-06-20 23:00:44 UTC ydbd size 2.2 GiB changed* by +1.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9d614bb merge: 50dab8b diff diff %
ydbd size 2 378 361 152 Bytes 2 378 362 520 Bytes +1.3 KiB +0.000%
ydbd stripped size 498 343 016 Bytes 498 343 400 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 20, 2025

2025-06-20 21:32:25 UTC Pre-commit check linux-x86_64-release-asan for 50dab8b has started.
2025-06-20 21:32:36 UTC Artifacts will be uploaded here
2025-06-20 21:35:57 UTC ya make is running...
🟡 2025-06-20 23:24:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14347 13918 0 151 250 28

2025-06-20 23:26:05 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-21 00:03:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1940 (only retried tests) 1651 0 78 185 26

2025-06-21 00:03:33 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-21 00:37:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1647 (only retried tests) 1382 0 61 178 26

🟢 2025-06-21 00:37:46 UTC Build successful.
🟢 2025-06-21 00:38:24 UTC ydbd size 3.9 GiB changed* by +1.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9d614bb merge: 50dab8b diff diff %
ydbd size 4 183 682 696 Bytes 4 183 684 632 Bytes +1.9 KiB +0.000%
ydbd stripped size 1 450 421 272 Bytes 1 450 421 656 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitstn vitstn merged commit 4b5dfba into ydb-platform:main Jun 22, 2025
16 checks passed
@vitstn vitstn deleted the prepare_remove_fields_providers branch June 22, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants