Skip to content

Fix bug with long timeout when consumer left ungracefully (#19503) #20104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nerhneiro
Copy link
Collaborator

@nerhneiro nerhneiro commented Jun 24, 2025

Changelog entry

Fix bug with long 5 min timeout while rebalancing if there was an ungraceful consumer in a group.

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Аналогичный PR в main: #19503

…rm#19503)

Co-authored-by: Irina Skvortsova <nerhneiro@yandex-team.ru>
@nerhneiro nerhneiro requested a review from a team as a code owner June 24, 2025 12:03
@nerhneiro nerhneiro marked this pull request as draft June 24, 2025 12:03
Copy link

github-actions bot commented Jun 24, 2025

2025-06-24 12:05:29 UTC Pre-commit check linux-x86_64-release-asan for 0b9286e has started.
2025-06-24 12:05:39 UTC Artifacts will be uploaded here
2025-06-24 12:08:30 UTC ya make is running...
🟡 2025-06-24 13:19:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12045 11911 0 31 67 36

2025-06-24 13:20:46 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-24 13:40:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
172 (only retried tests) 71 0 8 59 34

2025-06-24 13:41:06 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-24 14:00:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
130 (only retried tests) 44 0 7 45 34

🟢 2025-06-24 14:01:00 UTC Build successful.
🟢 2025-06-24 14:01:28 UTC ydbd size 3.7 GiB changed* by +13.8 KiB, which is < 100.0 KiB vs stable-25-1-2: OK

ydbd size dash stable-25-1-2: 11c9f55 merge: 0b9286e diff diff %
ydbd size 3 927 687 624 Bytes 3 927 701 800 Bytes +13.8 KiB +0.000%
ydbd stripped size 1 373 422 832 Bytes 1 373 433 648 Bytes +10.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 24, 2025

2025-06-24 12:05:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0b9286e has started.
2025-06-24 12:05:41 UTC Artifacts will be uploaded here
2025-06-24 12:08:29 UTC ya make is running...
🟡 2025-06-24 13:05:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18886 17608 0 2 1213 63

2025-06-24 13:07:21 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-24 13:30:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
131 (only retried tests) 69 0 0 6 56

🟢 2025-06-24 13:30:27 UTC Build successful.
🟢 2025-06-24 13:30:56 UTC ydbd size 2.1 GiB changed* by +11.6 KiB, which is < 100.0 KiB vs stable-25-1-2: OK

ydbd size dash stable-25-1-2: aca54ab merge: 0b9286e diff diff %
ydbd size 2 257 901 336 Bytes 2 257 913 184 Bytes +11.6 KiB +0.001%
ydbd stripped size 477 951 576 Bytes 477 955 160 Bytes +3.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 24, 2025

🟢 2025-06-27 14:59:56 UTC The validation of the Pull Request description is successful.

@nerhneiro nerhneiro marked this pull request as ready for review June 24, 2025 14:52
@a-serebryanskiy a-serebryanskiy merged commit 3440def into ydb-platform:stable-25-1-2 Jul 2, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants