Skip to content

[docs] update review.md with details about backports #20142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2025

Conversation

blinkov
Copy link
Member

@blinkov blinkov commented Jun 25, 2025

Changelog entry

...

Changelog category

  • Documentation (changelog entry is not required)

Description for reviewers

...

@blinkov blinkov requested a review from a team as a code owner June 25, 2025 04:14
@blinkov blinkov requested a review from Copilot June 25, 2025 04:14
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 25, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the documentation review guide by distinguishing review steps for new main-branch content and backported changes.

  • Adds a placeholder section for main-branch PR guidance
  • Introduces a detailed backport review checklist
  • Clarifies branching and publication process for stable-branch backports
Comments suppressed due to low confidence (2)

ydb/docs/en/core/contributor/documentation/review.md:57

  • This section is currently empty. Either populate it with the expected review steps for new main-branch PRs or remove the placeholder heading.
## If the PR is new content for the main branch

ydb/docs/en/core/contributor/documentation/review.md:57

  • The heading level here matches the top-level checklist heading. Consider using a third-level heading (###) to nest it under the main Checklist section for better structure.
## If the PR is new content for the main branch

Copy link

🟢 2025-06-25 04:15:33 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jun 25, 2025

2025-06-25 04:17:49 UTC Pre-commit check linux-x86_64-release-asan for c47fd83 has started.
2025-06-25 04:17:59 UTC Artifacts will be uploaded here
2025-06-25 04:20:19 UTC ya make is running...
🟢 2025-06-25 04:20:24 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-06-25 04:20:30 UTC Build successful.

Copy link

github-actions bot commented Jun 25, 2025

2025-06-25 04:18:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for c47fd83 has started.
2025-06-25 04:18:12 UTC Artifacts will be uploaded here
2025-06-25 04:20:39 UTC ya make is running...
🟢 2025-06-25 04:20:45 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-06-25 04:20:50 UTC Build successful.

@ydbot
Copy link
Collaborator

ydbot commented Jun 25, 2025

🔄 New commits pushed — @anton-bobkov please take a look.

Copy link

github-actions bot commented Jun 25, 2025

2025-06-25 04:26:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for f4b86e2 has started.
2025-06-25 04:26:48 UTC Artifacts will be uploaded here
2025-06-25 04:29:09 UTC ya make is running...
🟢 2025-06-25 04:29:15 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-06-25 04:29:20 UTC Build successful.

Copy link

github-actions bot commented Jun 25, 2025

2025-06-25 04:27:39 UTC Pre-commit check linux-x86_64-release-asan for f4b86e2 has started.
2025-06-25 04:27:50 UTC Artifacts will be uploaded here
2025-06-25 04:30:14 UTC ya make is running...
🟢 2025-06-25 04:30:19 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-06-25 04:30:25 UTC Build successful.

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@ydbot
Copy link
Collaborator

ydbot commented Jul 3, 2025

🔄 New commits pushed — @anton-bobkov please take a look.

Copy link

github-actions bot commented Jul 3, 2025

2025-07-03 05:24:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for c2e5104 has started.
2025-07-03 05:24:25 UTC Artifacts will be uploaded here
2025-07-03 05:26:57 UTC ya make is running...
🟢 2025-07-03 05:27:03 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-03 05:27:09 UTC Build successful.

Copy link

github-actions bot commented Jul 3, 2025

2025-07-03 05:24:33 UTC Pre-commit check linux-x86_64-release-asan for c2e5104 has started.
2025-07-03 05:24:44 UTC Artifacts will be uploaded here
2025-07-03 05:27:12 UTC ya make is running...
🟢 2025-07-03 05:27:18 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-03 05:27:24 UTC Build successful.

Copy link

github-actions bot commented Jul 3, 2025

✅ Documentation build

Revision built successfully
Revision preview link

@blinkov blinkov merged commit 2f218e1 into main Jul 4, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants