Skip to content

Add YAML config validation on node init #20151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

mregrock
Copy link
Collaborator

Changelog entry

Add YAML config validation on node init

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@mregrock mregrock requested a review from a team as a code owner June 25, 2025 09:56
Copy link

🟢 2025-06-25 09:59:41 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jun 25, 2025

2025-06-25 09:59:44 UTC Pre-commit check linux-x86_64-release-asan for b8a65d2 has started.
2025-06-25 09:59:56 UTC Artifacts will be uploaded here
2025-06-25 10:02:36 UTC ya make is running...
🟡 2025-06-25 10:43:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1381 1224 0 20 130 7

🟢 2025-06-25 10:43:16 UTC Build successful.
🟡 2025-06-25 10:43:31 UTC ydbd size 3.9 GiB changed* by +294.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 94e006b merge: b8a65d2 diff diff %
ydbd size 4 191 905 632 Bytes 4 192 207 192 Bytes +294.5 KiB +0.007%
ydbd stripped size 1 453 130 520 Bytes 1 453 221 400 Bytes +88.8 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 25, 2025

2025-06-25 09:59:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for b8a65d2 has started.
2025-06-25 09:59:55 UTC Artifacts will be uploaded here
2025-06-25 10:02:25 UTC ya make is running...
🟡 2025-06-25 10:20:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2161 2147 0 1 9 4

2025-06-25 10:20:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-25 10:25:50 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27 (only retried tests) 20 0 0 2 5

🟢 2025-06-25 10:25:59 UTC Build successful.
🟡 2025-06-25 10:26:11 UTC ydbd size 2.2 GiB changed* by +177.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 94e006b merge: b8a65d2 diff diff %
ydbd size 2 382 783 848 Bytes 2 382 965 408 Bytes +177.3 KiB +0.008%
ydbd stripped size 498 851 368 Bytes 498 892 584 Bytes +40.2 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@mregrock mregrock force-pushed the node_init_validation branch from 7b480e9 to 4752eff Compare June 25, 2025 11:19
Copy link

github-actions bot commented Jun 25, 2025

2025-06-25 11:22:18 UTC Pre-commit check linux-x86_64-release-asan for 384da4b has started.
2025-06-25 11:22:30 UTC Artifacts will be uploaded here
2025-06-25 11:25:04 UTC ya make is running...
🟡 2025-06-25 12:07:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1381 1229 0 19 127 6

🟢 2025-06-25 12:08:10 UTC Build successful.
🟢 2025-06-25 12:08:26 UTC ydbd size 3.9 GiB changed* by +2.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: db0340a merge: 384da4b diff diff %
ydbd size 4 192 207 288 Bytes 4 192 210 064 Bytes +2.7 KiB +0.000%
ydbd stripped size 1 453 221 464 Bytes 1 453 222 776 Bytes +1.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 25, 2025

2025-06-25 11:22:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 384da4b has started.
2025-06-25 11:22:30 UTC Artifacts will be uploaded here
2025-06-25 11:24:59 UTC ya make is running...
🟢 2025-06-25 11:42:31 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2161 2147 0 0 9 5

🟢 2025-06-25 11:42:49 UTC Build successful.
🟢 2025-06-25 11:43:02 UTC ydbd size 2.2 GiB changed* by +1.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: db0340a merge: 384da4b diff diff %
ydbd size 2 382 965 408 Bytes 2 382 966 920 Bytes +1.5 KiB +0.000%
ydbd stripped size 498 892 584 Bytes 498 893 032 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@mregrock mregrock enabled auto-merge (squash) June 25, 2025 11:30
@mregrock mregrock merged commit 36357ee into ydb-platform:main Jun 25, 2025
12 checks passed
mregrock added a commit to mregrock/ydb that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants