-
Notifications
You must be signed in to change notification settings - Fork 696
merge to analytics stable kqp cpu scheduler fix use after free #20153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge to analytics stable kqp cpu scheduler fix use after free #20153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a use-after-free issue in the CPU scheduler, addresses a verify failure in the CPU limiter, and updates handling of resource weight in the node service.
- Fix CPU limiter verification by normalizing AmountCPULimit near zero.
- Refactor resource weight handling in the compute scheduler and node service for safety and clarity.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
ydb/core/tx/conveyor/service/service.cpp | Adds a check to reset AmountCPULimit to zero when near zero to prevent verify failures. |
ydb/core/kqp/runtime/kqp_compute_scheduler.cpp | Refactors resource weight check by caching the Enabled() call and loops through Params until fully purged. |
ydb/core/kqp/node_service/kqp_node_service.cpp | Adds an extra check with HasResourceWeight() to safely assign resource weight from the message. |
Comments suppressed due to low confidence (1)
ydb/core/kqp/runtime/kqp_compute_scheduler.cpp:190
- [nitpick] Consider renaming 'toerase' to 'keysToErase' for improved clarity.
std::vector<TParameterKey> toerase;
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
9e31902
into
ydb-platform:stable-25-1-analytics
Changelog entry
Fixed use after free in CPU scheduler, fixed verify fail in CS CPU limiter: #20116
Changelog category
Description for reviewers
Also fixed ResourceWeight enable