Skip to content

Bridge Mode in CMS: Ignore proxy groups #20198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

stanislav-shchetinin
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Вмержить после: #20135

Проставляю для NKikimrBlobStorage::TBaseConfig::TGroup признак IsProxyGroup, означающий, что группа будет проигнорирована при проверках в CMS, соотвественно, в информацию о кластере ее не добавляю

@stanislav-shchetinin stanislav-shchetinin requested a review from a team as a code owner June 25, 2025 17:24
@stanislav-shchetinin stanislav-shchetinin linked an issue Jun 25, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Jun 25, 2025

2025-06-25 17:25:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1f3f61d has started.
2025-06-25 17:26:05 UTC Artifacts will be uploaded here
2025-06-25 17:29:55 UTC ya make is running...
🟡 2025-06-25 19:23:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38963 36253 0 4 2669 37

2025-06-25 19:26:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-25 19:39:50 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
312 (only retried tests) 282 0 0 2 28

🟢 2025-06-25 19:39:58 UTC Build successful.
🟢 2025-06-25 19:40:19 UTC ydbd size 2.2 GiB changed* by +25.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 208ff8d merge: 1f3f61d diff diff %
ydbd size 2 382 766 408 Bytes 2 382 792 584 Bytes +25.6 KiB +0.001%
ydbd stripped size 498 887 144 Bytes 498 890 824 Bytes +3.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 25, 2025

2025-06-25 17:26:06 UTC Pre-commit check linux-x86_64-release-asan for 1f3f61d has started.
2025-06-25 17:26:16 UTC Artifacts will be uploaded here
2025-06-25 17:29:58 UTC ya make is running...
🟡 2025-06-25 19:45:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16631 16333 0 74 196 28

🟢 2025-06-25 19:46:34 UTC Build successful.
🟢 2025-06-25 19:47:00 UTC ydbd size 3.9 GiB changed* by +48.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 208ff8d merge: 1f3f61d diff diff %
ydbd size 4 191 898 408 Bytes 4 191 947 592 Bytes +48.0 KiB +0.001%
ydbd stripped size 1 453 185 144 Bytes 1 453 199 384 Bytes +13.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

🟢 2025-06-25 17:27:14 UTC The validation of the Pull Request description is successful.

@stanislav-shchetinin stanislav-shchetinin added the rebase-and-check Rebase PR with the current base branch and check label Jun 25, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jun 25, 2025
Copy link

github-actions bot commented Jun 25, 2025

2025-06-25 20:51:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0415bb3 has started.
2025-06-25 20:51:31 UTC Artifacts will be uploaded here
2025-06-25 20:55:49 UTC ya make is running...
2025-06-25 21:20:46 UTC Check cancelled

Copy link

github-actions bot commented Jun 25, 2025

2025-06-25 20:51:35 UTC Pre-commit check linux-x86_64-release-asan for 0415bb3 has started.
2025-06-25 20:51:48 UTC Artifacts will be uploaded here
2025-06-25 20:55:35 UTC ya make is running...
2025-06-25 21:20:46 UTC Check cancelled

Copy link

github-actions bot commented Jun 25, 2025

2025-06-25 21:23:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for b22da1d has started.
2025-06-25 21:23:18 UTC Artifacts will be uploaded here
2025-06-25 21:26:54 UTC ya make is running...
🟡 2025-06-25 22:53:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38372 35639 0 15 2681 37

2025-06-25 22:56:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-25 23:08:47 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
803 (only retried tests) 728 0 0 49 26

🟢 2025-06-25 23:08:57 UTC Build successful.
🟢 2025-06-25 23:09:19 UTC ydbd size 2.2 GiB changed* by +3.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 63058f0 merge: b22da1d diff diff %
ydbd size 2 383 108 552 Bytes 2 383 111 656 Bytes +3.0 KiB +0.000%
ydbd stripped size 498 964 424 Bytes 498 965 064 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 25, 2025

2025-06-25 21:23:44 UTC Pre-commit check linux-x86_64-release-asan for b22da1d has started.
2025-06-25 21:23:55 UTC Artifacts will be uploaded here
2025-06-25 21:27:37 UTC ya make is running...
🟡 2025-06-25 23:31:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16054 15614 0 140 264 36

🟢 2025-06-25 23:32:47 UTC Build successful.
🟢 2025-06-25 23:33:15 UTC ydbd size 3.9 GiB changed* by +5.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 63058f0 merge: b22da1d diff diff %
ydbd size 4 192 746 592 Bytes 4 192 752 384 Bytes +5.7 KiB +0.000%
ydbd stripped size 1 453 455 672 Bytes 1 453 457 784 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc requested a review from alexvru June 26, 2025 07:42
Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужно не забыть про тесты.

@stanislav-shchetinin stanislav-shchetinin merged commit 4187651 into ydb-platform:main Jun 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge Mode in CMS: ignore proxy groups
4 participants