Skip to content

Check iter index access slice bounds in Reverse #20225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025

Conversation

kunga
Copy link
Member

@kunga kunga commented Jun 26, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

The same as in #18151 but for reverse

Doesn't effect scans, but worth fixing

@kunga kunga requested a review from a team as a code owner June 26, 2025 10:23
@kunga kunga requested a review from snaury June 26, 2025 10:23
Copy link

🟢 2025-06-26 10:24:00 UTC The validation of the Pull Request description is successful.

@kunga kunga force-pushed the fix-prev-bounds branch from 0e240d9 to 4d79b06 Compare June 26, 2025 10:26
Copy link

github-actions bot commented Jun 26, 2025

2025-06-26 10:27:26 UTC Pre-commit check linux-x86_64-release-asan for 37dc31d has started.
2025-06-26 10:27:48 UTC Artifacts will be uploaded here
2025-06-26 10:31:51 UTC ya make is running...
🟡 2025-06-26 12:45:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15823 15405 0 116 268 34

🟢 2025-06-26 12:46:27 UTC Build successful.
🟢 2025-06-26 12:46:55 UTC ydbd size 3.9 GiB changed* by +768 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 093001b merge: 37dc31d diff diff %
ydbd size 4 192 778 160 Bytes 4 192 778 928 Bytes +768 Bytes +0.000%
ydbd stripped size 1 453 500 856 Bytes 1 453 500 856 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 26, 2025

2025-06-26 10:32:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 37dc31d has started.
2025-06-26 10:33:05 UTC Artifacts will be uploaded here
2025-06-26 10:36:40 UTC ya make is running...
🟡 2025-06-26 12:20:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38099 35387 0 2 2670 40

2025-06-26 12:23:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-26 12:35:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
537 (only retried tests) 501 0 0 8 28

🟢 2025-06-26 12:35:40 UTC Build successful.
🟢 2025-06-26 12:35:59 UTC ydbd size 2.2 GiB changed* by -240 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 093001b merge: 37dc31d diff diff %
ydbd size 2 383 122 576 Bytes 2 383 122 336 Bytes -240 Bytes -0.000%
ydbd stripped size 498 976 712 Bytes 498 976 712 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga merged commit 0982e87 into ydb-platform:main Jul 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants