Skip to content

Generate config with right number of replicas in distconf #20249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 2, 2025
Merged

Generate config with right number of replicas in distconf #20249

merged 4 commits into from
Jul 2, 2025

Conversation

Evgenik2
Copy link
Collaborator

Changelog entry

Generate config with right number of replicas in distconf

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@Evgenik2 Evgenik2 marked this pull request as draft June 26, 2025 15:27
@Evgenik2 Evgenik2 self-assigned this Jun 26, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2025 •
edited
Loading

⚪ 2025-06-26 15:28:53 UTC Pre-commit check linux-x86_64-release-asan for 18b2fc3 has started.
⚪ 2025-06-26 15:29:10 UTC Artifacts will be uploaded here
⚪ 2025-06-26 15:31:41 UTC ya make is running...
🟢 2025-06-26 15:33:44 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26 26 0 0 0 0

🟢 2025-06-26 15:33:50 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2025 •
edited
Loading

⚪ 2025-06-26 15:29:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 18b2fc3 has started.
⚪ 2025-06-26 15:30:20 UTC Artifacts will be uploaded here
⚪ 2025-06-26 15:33:33 UTC ya make is running...
🟢 2025-06-26 15:35:19 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26 26 0 0 0 0

🟢 2025-06-26 15:35:26 UTC Build successful.

@github-actions GitHub Actions
Copy link

🟢 2025-06-26 15:30:38 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 30, 2025 •
edited
Loading

⚪ 2025-06-30 10:42:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8b5853a has started.
⚪ 2025-06-30 10:43:34 UTC Artifacts will be uploaded here
⚪ 2025-06-30 10:47:34 UTC ya make is running...
🟡 2025-06-30 11:49:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29773 28173 0 49 1513 38

⚪ 2025-06-30 11:51:49 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-30 12:01:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
529 (only retried tests) 428 0 0 78 23

🟢 2025-06-30 12:01:28 UTC Build successful.
🟢 2025-06-30 12:01:47 UTC ydbd size 2.2 GiB changed* by +19.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 89bf6bc merge: 8b5853a diff diff %
ydbd size 2 384 956 304 Bytes 2 384 975 784 Bytes +19.0 KiB +0.001%
ydbd stripped size 499 211 816 Bytes 499 214 120 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 30, 2025 •
edited
Loading

⚪ 2025-06-30 10:45:08 UTC Pre-commit check linux-x86_64-release-asan for 8b5853a has started.
⚪ 2025-06-30 10:45:20 UTC Artifacts will be uploaded here
⚪ 2025-06-30 10:48:45 UTC ya make is running...
🟡 2025-06-30 12:27:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14407 14018 0 170 191 28

🟢 2025-06-30 12:29:13 UTC Build successful.
🟢 2025-06-30 12:29:39 UTC ydbd size 3.9 GiB changed* by +30.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 89bf6bc merge: 8b5853a diff diff %
ydbd size 4 195 943 656 Bytes 4 195 975 136 Bytes +30.7 KiB +0.001%
ydbd stripped size 1 454 284 056 Bytes 1 454 291 736 Bytes +7.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 30, 2025 •
edited
Loading

⚪ 2025-06-30 13:09:06 UTC Pre-commit check linux-x86_64-release-asan for 3c3cdc0 has started.
⚪ 2025-06-30 13:09:09 UTC Artifacts will be uploaded here
⚪ 2025-06-30 13:12:53 UTC ya make is running...
🟡 2025-06-30 15:35:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16252 15868 0 119 230 35

🟢 2025-06-30 15:36:47 UTC Build successful.
🟢 2025-06-30 15:37:17 UTC ydbd size 3.9 GiB changed* by +44.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6eca081 merge: 3c3cdc0 diff diff %
ydbd size 4 195 941 792 Bytes 4 195 987 192 Bytes +44.3 KiB +0.001%
ydbd stripped size 1 454 286 296 Bytes 1 454 298 520 Bytes +11.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 30, 2025 •
edited
Loading

⚪ 2025-06-30 13:09:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3c3cdc0 has started.
⚪ 2025-06-30 13:10:05 UTC Artifacts will be uploaded here
⚪ 2025-06-30 13:13:39 UTC ya make is running...
🟡 2025-06-30 14:55:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38674 35956 0 4 2671 43

⚪ 2025-06-30 14:58:47 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-30 15:08:35 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
338 (only retried tests) 304 0 0 2 32

🟢 2025-06-30 15:08:45 UTC Build successful.
🟢 2025-06-30 15:09:06 UTC ydbd size 2.2 GiB changed* by +27.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6eca081 merge: 3c3cdc0 diff diff %
ydbd size 2 384 956 536 Bytes 2 384 984 536 Bytes +27.3 KiB +0.001%
ydbd stripped size 499 213 928 Bytes 499 217 544 Bytes +3.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Evgenik2 Evgenik2 requested a review from alexvru July 1, 2025 08:26
@Evgenik2 Evgenik2 marked this pull request as ready for review July 1, 2025 08:26
@Evgenik2 Evgenik2 enabled auto-merge (squash) July 1, 2025 08:26
@Evgenik2 Evgenik2 force-pushed the Generate-config-with-right-number-of-replicas-in-distconf branch from 86fbff1 to d370196 Compare July 2, 2025 10:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2025 •
edited
Loading

⚪ 2025-07-02 10:50:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5357f5d has started.
⚪ 2025-07-02 10:50:58 UTC Artifacts will be uploaded here
⚪ 2025-07-02 10:55:11 UTC ya make is running...
🟡 2025-07-02 12:39:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38776 36048 0 5 2679 44

⚪ 2025-07-02 12:42:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-02 12:53:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
634 (only retried tests) 597 0 1 2 34

⚪ 2025-07-02 12:53:30 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-07-02 13:03:12 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
273 (only retried tests) 242 0 0 2 29

🟢 2025-07-02 13:03:22 UTC Build successful.
🟢 2025-07-02 13:03:44 UTC ydbd size 2.2 GiB changed* by +39.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e64dff8 merge: 5357f5d diff diff %
ydbd size 2 387 523 400 Bytes 2 387 563 712 Bytes +39.4 KiB +0.002%
ydbd stripped size 499 555 688 Bytes 499 565 320 Bytes +9.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2025 •
edited
Loading

⚪ 2025-07-02 10:51:46 UTC Pre-commit check linux-x86_64-release-asan for 5357f5d has started.
⚪ 2025-07-02 10:51:57 UTC Artifacts will be uploaded here
⚪ 2025-07-02 10:55:50 UTC ya make is running...
🟡 2025-07-02 13:14:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16335 15971 0 136 196 32

🟢 2025-07-02 13:15:33 UTC Build successful.
🟡 2025-07-02 13:16:02 UTC ydbd size 3.9 GiB changed* by +217.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9f38b92 merge: 5357f5d diff diff %
ydbd size 4 199 790 080 Bytes 4 200 012 504 Bytes +217.2 KiB +0.005%
ydbd stripped size 1 455 254 392 Bytes 1 455 307 000 Bytes +51.4 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Evgenik2 Evgenik2 merged commit c6046d7 into main Jul 2, 2025
13 checks passed
@Evgenik2 Evgenik2 linked an issue Jul 24, 2025 that may be closed by this pull request
Generate config with right number of replicas in distconf #20211
Closed
@Evgenik2 Evgenik2 deleted the Generate-config-with-right-number-of-replicas-in-distconf branch July 25, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvru alexvru

Assignees

@Evgenik2 Evgenik2

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate config with right number of replicas in distconf
2 participants
@Evgenik2 @alexvru