Add YDB CLI 2.23.0 release notes #20258
Conversation
github-actions
bot
added
the
documentation
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
🟢 |
✅ Documentation buildRevision built successfully |
|
|
||
| ### Bug fixes | ||
|
|
||
| * Fixed an issue where the `{{ ydb-cli }} workload * clean` [commands](./reference/ydb-cli/commands/workload) were deleting all contents from the target directory, instead of just the tables created by the init command. | ||
| * Fixed an issue where the `{{ ydb-cli }} workload * clean` [commands](./reference/ydb-cli/commands/workload/index.md) were deleting all contents from the target directory, instead of just the tables created by the init command. |
There was a problem hiding this comment.
| * Fixed an issue where the `{{ ydb-cli }} workload * clean` [commands](./reference/ydb-cli/commands/workload/index.md) were deleting all contents from the target directory, instead of just the tables created by the init command. | |
| * Fixed an issue where the `{{ ydb-cli }} workload * clean` [commands](./reference/ydb-cli/commands/workload/index.md) deleted the entire contents of the target directory, not just tables created by the init command. |
There was a problem hiding this comment.
Это место про предыдущий релиз, уже было согласовано. И мне кажется, что существующая формулировка более правильная, т.к. это происходило каждый запуск
There was a problem hiding this comment.
команды... удаляли (факт)... - мне кажется, не надо тут никакого continuous, чем проще в доке грамматика - тем лучше. Но пусть @blinkov решит
There was a problem hiding this comment.
проще и правда при прочих равных лучше, т.е. если сравнивать чисто формулировки я б выбрал новую, но исходная правка тут вообще просто ссылку заодно чинит — снежный ком с существенным пересмотром старого контента из-за такого лучше не устраивать, по крайней мере в том же PR
There was a problem hiding this comment.
если сравнивать чисто формулировки я б выбрал новую
А чем новая формулировка лучше? "Команда удалила содержимое " звучит так, будто был один какой-то инцидент с удалением контента. А проблема была именно в том, что при запуске команды она каждый раз систематически удаляла это содержимое.
Это даёт совсем другой смысл.
There was a problem hiding this comment.
Предлагаю оставить эту строку как есть в PR: она про приведение ссылок к общему виду со ссылкой в новой команде. С предлагаемым изменением текста предыдущей версии я не согласен, т.к. на мой взгляд теряется смысл написанного. Предлагаю не блочить этот PR, т.к. он не призван менять текст ранее опубликованных версий.
|
🔄 New commits pushed — @ElenaAfina please take a look. |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
✅ Documentation buildRevision built successfully |
|
|
||
| ### Bug fixes | ||
|
|
||
| * Fixed an issue where the `{{ ydb-cli }} workload * clean` [commands](./reference/ydb-cli/commands/workload) were deleting all contents from the target directory, instead of just the tables created by the init command. | ||
| * Fixed an issue where the `{{ ydb-cli }} workload * clean` [commands](./reference/ydb-cli/commands/workload/index.md) were deleting all contents from the target directory, instead of just the tables created by the init command. |
There was a problem hiding this comment.
команды... удаляли (факт)... - мне кажется, не надо тут никакого continuous, чем проще в доке грамматика - тем лучше. Но пусть @blinkov решит
|
🔄 New commits pushed — @ElenaAfina please take a look. |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
✅ Documentation buildRevision built successfully |
|
Проблемы со сборкой YDB CLI на Windows. Пока не разберемся, не стоит мерджить этот PR. |
|
Hey @ElenaAfina, it has been 77 business-hours since the author's last update, could you please review? |
|
🔄 New commits pushed — @ElenaAfina please take a look. |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
✅ Documentation buildRevision built successfully |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
Hey @ElenaAfina, it has been 107 business-hours since the author's last update, could you please review? |
ydb/docs/en/core/changelog-cli.md
Outdated
| * Added the `{{ ydb-cli }} workload tpcc` command as a TPC-C benchmark. | ||
| * Added the `{{ ydb-cli }} workload vector select` command to benchmark vector index performance and recall. | ||
| * Added the `{{ ydb-cli }} tools infer csv` command to generate a `CREATE TABLE` SQL query from a CSV data file. |
There was a problem hiding this comment.
Missing links to documentation on all of these
There was a problem hiding this comment.
The documentation itself is missing for the first two, AFAIK.
For the last one PR is on review for 2 weeks now #20012
|
|
||
| ### Bug fixes | ||
|
|
||
| * Fixed an issue where the `{{ ydb-cli }} workload * clean` [commands](./reference/ydb-cli/commands/workload) were deleting all contents from the target directory, instead of just the tables created by the init command. | ||
| * Fixed an issue where the `{{ ydb-cli }} workload * clean` [commands](./reference/ydb-cli/commands/workload/index.md) were deleting all contents from the target directory, instead of just the tables created by the init command. |
There was a problem hiding this comment.
проще и правда при прочих равных лучше, т.е. если сравнивать чисто формулировки я б выбрал новую, но исходная правка тут вообще просто ссылку заодно чинит — снежный ком с существенным пересмотром старого контента из-за такого лучше не устраивать, по крайней мере в том же PR
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
🔄 New commits pushed — @ElenaAfina please take a look. |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
✅ Documentation buildRevision built successfully |
|
Hey @ElenaAfina, it has been 26 business-hours since the author's last update, could you please review? |
|
Hey @ElenaAfina, it has been 56 business-hours since the author's last update, could you please review? |
|
Hey @ElenaAfina, it has been 80 business-hours since the author's last update, could you please review? |
|
Hey @ElenaAfina, it has been 110 business-hours since the author's last update, could you please review? |
|
Hey @ElenaAfina, it has been 140 business-hours since the author's last update, could you please review? |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
🔄 New commits pushed — @ElenaAfina please take a look. |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
✅ Documentation buildRevision built successfully |
|
Hey @ElenaAfina, it has been 176 business-hours since the author's last update, could you please review? |
|
Hey @ElenaAfina, it has been 206 business-hours since the author's last update, could you please review? |
Changelog entry
Changelog category
Description for reviewers