Skip to content

Bridge Mode support in Scheme Board subscriber: ignore disconnected piles #20263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 27, 2025

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Jun 26, 2025

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Epic:

Issue:

Copy link

🟢 2025-06-26 17:14:29 UTC The validation of the Pull Request description is successful.

This comment was marked as outdated.

This comment was marked as outdated.

@jepett0 jepett0 linked an issue Jun 26, 2025 that may be closed by this pull request
@jepett0 jepett0 marked this pull request as ready for review June 26, 2025 17:26
@jepett0 jepett0 requested a review from a team as a code owner June 26, 2025 17:26
@jepett0 jepett0 requested review from CyberROFL and Evgenik2 June 26, 2025 17:42

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@Evgenik2 Evgenik2 self-requested a review June 27, 2025 07:38
@jepett0 jepett0 requested a review from CyberROFL June 27, 2025 09:35
@jepett0 jepett0 added the rebase-and-check Rebase PR with the current base branch and check label Jun 27, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jun 27, 2025
Copy link

github-actions bot commented Jun 27, 2025

2025-06-27 09:36:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 43ff609 has started.
2025-06-27 09:37:48 UTC Artifacts will be uploaded here
2025-06-27 09:41:42 UTC ya make is running...
🟡 2025-06-27 10:40:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29827 28440 0 3 1352 32

2025-06-27 10:43:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-27 10:55:27 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
86 (only retried tests) 59 0 0 2 25

🟢 2025-06-27 10:55:34 UTC Build successful.
🟢 2025-06-27 10:55:52 UTC ydbd size 2.2 GiB changed* by +480 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 43e3bd9 merge: 43ff609 diff diff %
ydbd size 2 383 691 928 Bytes 2 383 692 408 Bytes +480 Bytes +0.000%
ydbd stripped size 499 055 912 Bytes 499 056 040 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 27, 2025

2025-06-27 09:39:44 UTC Pre-commit check linux-x86_64-release-asan for 43ff609 has started.
2025-06-27 09:39:55 UTC Artifacts will be uploaded here
2025-06-27 09:43:13 UTC ya make is running...
🟡 2025-06-27 11:25:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14462 14130 0 110 193 29

🟢 2025-06-27 11:26:51 UTC Build successful.
🟢 2025-06-27 11:27:17 UTC ydbd size 3.9 GiB changed* by +304 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 43e3bd9 merge: 43ff609 diff diff %
ydbd size 4 193 782 216 Bytes 4 193 782 520 Bytes +304 Bytes +0.000%
ydbd stripped size 1 453 760 024 Bytes 1 453 760 088 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL
Copy link
Member

@jepett0 наверно, имеет смысл сделать то, о чем пишет @Evgenik2, если после этих изменений не придется сильно переделывать тесты. Ну, или как минимум завести issue на улучшение. Прямо сейчас оно должно работать корректно.

@jepett0 jepett0 merged commit 5deb213 into ydb-platform:main Jun 27, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge Mode in SB: support two-level quorum in subscribers
3 participants