Skip to content

Conversation

nikola-jokic
Copy link
Collaborator

This pull request introduces several changes to enhance the end-to-end testing capabilities of the project. The most important changes include adding a new bash script for running end-to-end tests, updating the GitHub Actions workflow to include a new job for running end-to-end tests, and adding new targets and scripts to facilitate running tests locally.

Main changes:

  • hack/e2e-test.sh: Added a new bash script responsible for running end-to-end tests.
  • .github/workflows/gha-e2e-tests.yaml: Added a new job to the GitHub Actions workflow file for running end-to-end tests.
  • Makefile: Added a new target to facilitate running end-to-end tests locally.

Additional changes:

  • test/actions.github.com/envrc.example: Added environment variables for configuring target organization, repository, and GitHub token in end-to-end tests.
  • test/actions.github.com/default-setup.test.sh: Added a new bash script for testing the default setup of the GitHub Actions runner scale set.
  • test/actions.github.com/helper.sh: Added a new bash script containing helper functions used in the end-to-end tests.

@nikola-jokic nikola-jokic requested review from a team, mumoshu and toast-gear as code owners December 7, 2023 14:09
@nikola-jokic nikola-jokic added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Dec 7, 2023
rentziass
rentziass previously approved these changes Mar 18, 2024
Copy link
Member

@rentziass rentziass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nikola-jokic nikola-jokic force-pushed the nikola-jokic/e2e-setup-and-default-test branch from 195ef3a to 3a10e3e Compare April 3, 2025 12:42
@nikola-jokic nikola-jokic marked this pull request as draft May 14, 2025 14:43
@nikola-jokic nikola-jokic force-pushed the nikola-jokic/e2e-setup-and-default-test branch from 512655f to 4236ff0 Compare June 9, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gha-runner-scale-set Related to the gha-runner-scale-set mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants