Delete config secret when listener pod gets deleted #4033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix actions#4029. When the github token gets updated, and the old one expires, the listener pod dies. Only to be recreated with the existing listener config that holds the now expired token. This PR fixes that by deleting the config secret as well, so the reconciler recreates it with the updated token.
hsmade
requested review from
mumoshu,
toast-gear,
nikola-jokic,
rentziass and
a team
as code owners
4 tasks
nikola-jokic
requested changes
May 6, 2025
Comment on lines
+266
to
+275
| err := r.Get(ctx, types.NamespacedName{Namespace: autoscalingListener.Namespace, Name: scaleSetListenerConfigName(autoscalingListener)}, &configSecret) | ||
| switch { | ||
| case err == nil: | ||
| if configSecret.ObjectMeta.DeletionTimestamp.IsZero() { | ||
| log.Info("Deleting the listener config secret") | ||
| if err := r.Delete(ctx, &configSecret); err != nil { | ||
| return ctrl.Result{}, fmt.Errorf("failed to delete listener config secret: %w", err) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| err := r.Get(ctx, types.NamespacedName{Namespace: autoscalingListener.Namespace, Name: scaleSetListenerConfigName(autoscalingListener)}, &configSecret) | |
| switch { | |
| case err == nil: | |
| if configSecret.ObjectMeta.DeletionTimestamp.IsZero() { | |
| log.Info("Deleting the listener config secret") | |
| if err := r.Delete(ctx, &configSecret); err != nil { | |
| return ctrl.Result{}, fmt.Errorf("failed to delete listener config secret: %w", err) | |
| } | |
| } | |
| } | |
| err := r.Get(ctx, types.NamespacedName{Namespace: autoscalingListener.Namespace, Name: scaleSetListenerConfigName(autoscalingListener)}, &configSecret) | |
| switch { | |
| case err == nil && configSecret.ObjectMeta.DeletionTimestamp.IsZero(): | |
| log.Info("Deleting the listener config secret") | |
| if err := r.Delete(ctx, &configSecret); err != nil { | |
| return ctrl.Result{}, fmt.Errorf("failed to delete listener config secret: %w", err) | |
| } | |
| case !kerrors.IsNotFound(err): | |
| return ctrl.Result{}, fmt.Errorf("failed to get the listener config secret: %w", err) | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #4029. When the github token gets updated, and the old one expires, the listener pod dies. Only to be recreated with the existing listener config that holds the now expired token. This PR fixes that by deleting the config secret as well, so the reconciler recreates it with the updated token.