-
Notifications
You must be signed in to change notification settings - Fork 809
Open
Labels
feature requestNew feature or request to improve the current logicNew feature or request to improve the current logic
Description
Description:
Cache the Maven distribution downloaded by the official Maven Wrapper.
The cache key should probably be derived from the .mvn/wrapper/maven-wrapper.properties
file (see documentation), similar to how it is done already for the Gradle Wrapper.
The directory to cache is ~/.m2/wrapper/dists
(see documentation).
Justification:
Without caching, projects using the Maven Wrapper would have to download the Maven distribution (~8MB) every time the project is built.
For Gradle the setup-java action already supports caching the Gradle distribution downloaded by the wrapper:
Line 36 in 8f12c5c
'**/gradle-wrapper.properties', |
Line 32 in 8f12c5c
path: [join(os.homedir(), '.gradle', 'caches'), join(os.homedir(), '.gradle', 'wrapper')], |
Are you willing to submit a PR?
Probably not
yeikel, vorburger, fadma10, ouaibsky, cbugneac-nex and 4 more
Metadata
Metadata
Assignees
Labels
feature requestNew feature or request to improve the current logicNew feature or request to improve the current logic
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
IvanZosimov commentedon Jan 30, 2023
Hi, @Marcono1234 👋 Thank you for the feature request! We will investigate it and get back to you with our decision as soon as possible.
Cache Maven distribution downloaded by Maven Wrapper
Cache Maven Wrapper
Cache Maven Wrapper
Cache Maven Wrapper
yeikel commentedon Feb 16, 2023
@IvanZosimov I submitted #453 for this
fadma10 commentedon Apr 20, 2023
it's runing
seepine commentedon Jul 14, 2023
@yeikel Hi, maybe you can support gradlew also, this is really useful of cache mvnw and gradlew
yeikel commentedon Jul 14, 2023
I think that we should track that separately
seepine commentedon Jul 14, 2023
You are right, maybe not work of cache gradlew due to excessive cache size, i find it work just now.