Skip to content

Add support for multiple servers. #85

New issue
New issue
Open
Open
Add support for multiple servers.#85
#86 (+8)
Labels
feature requestNew feature or request to improve the current logic
@drewctaylor

Description

@drewctaylor
drewctaylor
opened on Jul 30, 2020

Currently, as I understand it, the user may specify only one server, as follows:

- name: Setup Java.
  uses: actions/setup-java@v1
  with:
    java-version: 1.8
    server-id: value-of-server-id
    server-username: SERVER_USERNAME
    server-password: SERVER_PASSWORD

Which produces the following xml in the settings.xml file:

<server>
  <id>value-of-server-id</id>
  <username>value-of-server-username</username>
  <password>value-of-server-password</password>
</server>

However, it would be useful to be able to specify more than one server. For example, this yaml:

- name: Setup Java.
  uses: actions/setup-java@v1
  with:
    java-version: 1.8
    server-list:
      - server-id: value-of-server-id-1
        server-username: SERVER_USERNAME_1
        server-password: SERVER_PASSWORD_1
      - server-id: value-of-server-id-2
        server-username: SERVER_USERNAME_2
        server-password: SERVER_PASSWORD_2

Might produce the following xml in the settings.xml file:

<server>
  <id>value-of-server-id-1</id>
  <username>value-of-server-username-1</username>
  <password>value-of-server-password-1</password>
</server>
<server>
  <id>value-of-server-id-2</id>
  <username>value-of-server-username-2</username>
  <password>value-of-server-password-2</password>
</server>

While it would be valuable in general to be able to specify more than one server, it should be especially valuable in the context of Github, as it seems for now, in order to reference multiple packages from maven.pkg.github.com, the user must reference each package's repository in their pom.xml.

If the above configuration were possible, a user could then reference the artifacts at value-of-server-id-1 and value-of-server-id-2 in their pom.xml as follows:

<dependencies>
  <dependency>
    <groupId>group-id-for-owner</groupId>
    <artifactId>artifact-id-from-repository-1</artifactId>
    <version>version-1</version>
  </dependency>

  <dependency>
    <groupId>group-id-for-owner</groupId>
    <artifactId>artifact-id-from-repository-2</artifactId>
    <version>version-2</version>
  </dependency>
</dependencies>

<repositories>
  <repository>
    <id>value-of-server-id-1</id>
    <name>GitHub Packages</name>
    <url>https://maven.pkg.github.com/owner/artifact-id-from-repository-1</url>
  </repository>
  <repository>
    <id>value-of-server-id-2</id>
    <name>GitHub Packages</name>
    <url>https://maven.pkg.github.com/owner/artifact-id-from-repository-2</url>
  </repository>
</repositories>

Activity

drewctaylor
added 3 commits that reference this issue on Aug 1, 2020

Fixes actions#85. Add support for multiple servers.

2b68012

Fixes actions#85. Add support for multiple server ids.

28e454b

Fixes actions#85. Add support for multiple server ids.

2a3b137
drewctaylor
linked a pull request that will close this issue on Aug 1, 2020
laurentgo
mentioned this on Oct 3, 2020
dmitry-shibanov
added
enhancement
feature requestNew feature or request to improve the current logic
on Jan 14, 2021
maxim-lobanov
removed
enhancement
on Feb 10, 2021
MCLonips

MCLonips commented on Apr 6, 2021

@MCLonips
MCLonips
on Apr 6, 2021

what is the current state of this issue?

perkam

perkam commented on May 10, 2021

@perkam
perkam
on May 10, 2021

Same question here. Is this feature on the roadmap? It would be really useful.

dmitry-shibanov

dmitry-shibanov commented on May 11, 2021

@dmitry-shibanov
dmitry-shibanov
on May 11, 2021
Contributor

Hello everyone. Unfortunately it's not possible to implement right now, because GitHub does not support multiple parameters for arguments. actions/toolkit#184

torrespro

torrespro commented on Nov 11, 2021

@torrespro
torrespro
on Nov 11, 2021

https://github.com/marketplace/actions/maven-settings-action

snyk-bot
linked a pull request that will close this issue on Jan 16, 2022
snyk-bot
linked a pull request that will close this issue on Feb 22, 2022
snyk-bot
linked a pull request that will close this issue on Apr 22, 2022
snyk-bot
linked a pull request that will close this issue on Apr 27, 2022
snyk-bot
linked a pull request that will close this issue on Jul 7, 2022
snyk-bot
linked a pull request that will close this issue on Sep 6, 2022
NOUIY
linked a pull request that will close this issue on Sep 9, 2022
NOUIY
linked a pull request that will close this issue on Oct 11, 2022
jsoref

jsoref commented on Mar 6, 2023

@jsoref
jsoref
on Mar 6, 2023

Surely this could be supported with either a toJSON / fromJSON or by taking a file parameter which contains the relevant content.

IvanZosimov
mentioned this on Mar 21, 2023
Andreiasilva1

Andreiasilva1 commented on Jun 13, 2023

@Andreiasilva1
Andreiasilva1
on Jun 13, 2023

Gostaria de saber como funciona

IvanZosimov
added
needs eyes
on Jul 3, 2023
IvanZosimov
linked a pull request that will close this issueFixes #85. Add support for multiple server ids. #86on Jul 3, 2023
IvanZosimov
removed
needs eyes
on Jul 27, 2023
Yaytay
mentioned this on Mar 26, 2024
kevinheins

kevinheins commented on Jul 18, 2024

@kevinheins
kevinheins
on Jul 18, 2024

This would be really helpful to have. @IvanZosimov you closed the duplicate #427, can you provide an update or ping who can push this forward?

roman-bicherschii

roman-bicherschii commented on Sep 17, 2024

@roman-bicherschii
roman-bicherschii
on Sep 17, 2024

I run into the same issue :-( ! Would be really neat to either

  1. be able to configure multiple servers,
  2. or to access all packages of a given organization via single organization's server: eg: https://maven.pkg.github.com// over https://maven.pkg.github.com//
fbonander

fbonander commented on Nov 28, 2024

@fbonander
fbonander
on Nov 28, 2024

@roman-bicherschii You can use wildcards to access multiple repos

https://maven.pkg.github.com/MyOrg/*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature requestNew feature or request to improve the current logic

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @torrespro@jsoref@drewctaylor@kevinheins@perkam

      Issue actions
        Add support for multiple servers. · Issue #85 · actions/setup-java