Fix license filter #2116
Merged
Fix license filter #2116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason we dont see the error about this license is that they scan diff instead of repo state: actions/dependency-review-action#922. MIT-CMU was my attempt to please it, but it seems that the reviewer uses .github/dependency_review.yml from the target branch only which is another their issue. The license in this commit feels to be more correct because it is the license printed in the error message https://github.com/openvinotoolkit/openvino.genai/actions/runs/14531018031/job/40770651373
ilya-lavrenov
approved these changes
Apr 25, 2025
apram0d
pushed a commit
to apram0d/openvino.genai
that referenced
this pull request
Apr 28, 2025
The reason we dont see the error about this license is that they scan diff instead of repo state: actions/dependency-review-action#922. MIT-CMU was my attempt to please it, but it seems that the reviewer uses .github/dependency_review.yml from the target branch only which is another their issue. The license in this commit feels to be more correct because it is the license printed in the error message https://github.com/openvinotoolkit/openvino.genai/actions/runs/14531018031/job/40770651373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason we dont see the error about this license is that they scan diff instead of repo state: actions/dependency-review-action#922. MIT-CMU was my attempt to please it, but it seems that the reviewer uses .github/dependency_review.yml from the target branch only which is another their issue. The license in this commit feels to be more correct because it is the license printed in the error message https://github.com/openvinotoolkit/openvino.genai/actions/runs/14531018031/job/40770651373