Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(mariadb): migrate test environment #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

refactor(mariadb): migrate test environment #1

wants to merge 7 commits into from

Conversation

tobias-chc
Copy link
Collaborator

@tobias-chc tobias-chc commented Mar 2, 2023 •
edited

Description

Migrate cluster test-environment to the last Nikita version, adding SSL certificates creation.

Main changes:

  • Nikita migration
  • Add test framework
  • Isolate test-environment test that are currently on the mariadb test (cluster status, ip addresses, ssl certificates)

wdavidw
wdavidw requested changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@wdavidw wdavidw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find the tests which validate the installation of the MariaDB server.

packages/mariadb/test/test.coffee Show resolved Hide resolved
packages/mariadb/test/env.coffee Show resolved Hide resolved
packages/mariadb/test/env.coffee Show resolved Hide resolved
@tobias-chc
Copy link
Collaborator Author

Yes there are no test of MariaDB, I'm only testing that the required cluster environment to perform the test works as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdavidw wdavidw wdavidw requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobias-chc @wdavidw