Skip to content

Compatibility: Removing import fallbacks as we no longer need to ensure compatiblity #44164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

coder-karen
Copy link
Contributor

@coder-karen coder-karen commented Jul 1, 2025

Fixes VULCAN-201

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

A code review should be sufficient, and then primarily testing on P2 as that was why compatibility was added:

  • Sandbox a P2 site, and apply these changes using the command in the generated comment below in your sandbox.
  • Visit the P2, and open up WP Admin in order to create a new post. In the post editor, attempt to add core blocks such as the checkbox block, task block. Also the gif block. These should work, as should auto-complete when using @ and +.
  • You can also test with comments on the P2 front-end (for example with @ and + autocomplete, and adding the task block and gif block - in order to replicate similar testing scenarios as were used when the issue from the earlier PR was present, you should also try adding ?concat=yes to the URL.
  • Open up the Jetpack sidebar after creating a new post in WP Admin. Ensure there are no warnings showing on the page.

However, to fully test all areas of code touched, then follow the testing steps in these PRs:

(note that you shouldn't be seeing console warnings at any stage of testing)

Some additional notes:

  • Rather than testing console warnings, more importantly test that functionality remains as expected.
  • For SEO testing, on self-hosted you'll need a Complete plan. Also, you may not see the auto-generated title etc in the Jetpack sidebar, but it should show in the pre-publish panel.
  • For the Compatibility (Post Editor to Site Editor) PR, The AI Assistant and Yoast Promo steps aren't relevant for SImple, nor the Payments Post Publish Panel
  • The Social PR steps can only be tested on self-hosted

Copy link
Contributor

github-actions bot commented Jul 1, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/gutenberg-wordpress-compatibility-conditionals branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/gutenberg-wordpress-compatibility-conditionals
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/gutenberg-wordpress-compatibility-conditionals

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Jul 1, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: August 5, 2025
    • Code freeze: August 4, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

jp-launch-control bot commented Jul 1, 2025

Code Coverage Summary

Coverage changed in 13 files. Only the first 5 are listed here.

File Coverage Δ% Δ Uncovered
projects/js-packages/publicize-components/src/components/block-editor/components/pre-publish-panels.tsx 0/5 (0.00%) 0.00% -1 💚
projects/js-packages/publicize-components/src/components/post-publish-manual-sharing/index.tsx 0/5 (0.00%) 0.00% -1 💚
projects/js-packages/publicize-components/src/components/post-publish-review-prompt/index.tsx 0/15 (0.00%) 0.00% -1 💚
projects/js-packages/publicize-components/src/components/post-publish-share-status/index.tsx 0/17 (0.00%) 0.00% -1 💚
projects/plugins/jetpack/extensions/blocks/premium-content/_inc/remove-block-keep-content.js 0/3 (0.00%) 0.00% -1 💚

Full summary · PHP report · JS report

@coder-karen coder-karen added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Jul 1, 2025
@coder-karen coder-karen marked this pull request as ready for review July 1, 2025 18:39
@coder-karen coder-karen requested a review from a team July 1, 2025 18:39
bindlegirl
bindlegirl previously approved these changes Jul 4, 2025
Copy link
Contributor

@bindlegirl bindlegirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM

@coder-karen coder-karen merged commit a692157 into trunk Jul 7, 2025
69 checks passed
@coder-karen coder-karen deleted the update/gutenberg-wordpress-compatibility-conditionals branch July 7, 2025 11:55
@github-actions github-actions bot removed [Status] In Progress [Status] Needs Review This PR is ready for review. labels Jul 7, 2025
@github-actions github-actions bot added this to the jetpack/14.9 milestone Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants