Skip to content

Remove sending is_singular_post parameter #44186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025

Conversation

timur987
Copy link
Contributor

@timur987 timur987 commented Jul 3, 2025

Related to ADS-295 and 187107-ghe-Automattic/wpcom

Proposed changes:

  • Remove sending is_singular_post to highlight the current URL is suitable for inline ads (because

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Testing instructions:

If you need to know more about how to get Jetpack tests site up and running, please take a look at 184618-ghe-Automattic/wpcom. Also, please don't forget to make your site launched and be public (use WP Admin > General > Reading section).

  • Make sure that you can see development ads (with the use of ?ad_dev=true)
image
  • And, the most important, inline ads:
Screenshot 2025-07-04 at 12 19 29

Troubleshooting

In the case you don't see ads due to af.pubmine.com/?api_version=2 returns 204 (the ad slot considered as Brand Unsafe), just switch to local AdFlow in WATL and run AdFlow locally.

Copy link
Contributor

github-actions bot commented Jul 3, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the remove/sending-is-singular-post branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack remove/sending-is-singular-post

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Ad [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Jul 3, 2025
Copy link
Contributor

github-actions bot commented Jul 3, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • 🔴 Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:

## Does this pull request change what data or activity we track or use?

My PR adds *x* and *y*.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: August 5, 2025
    • Code freeze: August 4, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 3, 2025
Copy link

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/modules/wordads/php/class-wordads-smart.php 0/88 (0.00%) 0.00% -1 💚

Full summary · PHP report · JS report

@timur987 timur987 self-assigned this Jul 4, 2025
@timur987 timur987 marked this pull request as ready for review July 4, 2025 09:27
@timur987 timur987 requested review from sbarbosa and therocket-gr July 4, 2025 09:27
Copy link
Contributor

@sbarbosa sbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.

I tested it and do not see the is_singular_post in the adflow/conf/ call. I also verified it by checking the stable version of Jetpack, and we sent it in that one.

I can also see the debug ad placement, including the inline ads.

Copy link
Contributor

@therocket-gr therocket-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in localhost with the other branch in my sandbox. works as described and code changes LGTM

@timur987 timur987 merged commit 6108a79 into trunk Jul 7, 2025
72 checks passed
@timur987 timur987 deleted the remove/sending-is-singular-post branch July 7, 2025 13:15
@github-actions github-actions bot added this to the jetpack/14.9 milestone Jul 7, 2025
@github-actions github-actions bot removed [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Ad [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants