Update/charts 49 chart context foundation #44189

annacmc · 2025-07-04T02:04:25Z

Fixes #

Proposed changes:

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Go to '..'

github-actions · 2025-07-04T02:05:29Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/charts-49-chart-context-foundation branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/charts-49-chart-context-foundation

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-07-04T02:05:43Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

jp-launch-control · 2025-07-04T02:17:10Z

Code Coverage Summary

Cannot generate coverage summary while tests are failing. 🤐

Please fix the tests, or re-run the Code coverage job if it was something being flaky.

Full summary · PHP report · JS report

Copilot

Pull Request Overview

This PR lays the groundwork for a new ChartContext system, enabling charts to register themselves and share metadata across components.

Introduce an optional chartId prop and auto-generated fallback
Add ChartProvider, useChartContext, useChartId, and useChartRegistration utilities
Integrate context registration into existing chart components (Pie, Semi-Pie, Line, Bar)

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
projects/js-packages/charts/src/types.ts	Added optional `chartId` to base chart props
projects/js-packages/charts/src/providers/chart-context/utils.ts	Implemented `useChartId` and `useChartRegistration` hooks
projects/js-packages/charts/src/providers/chart-context/types.ts	Defined types for chart registration entries
projects/js-packages/charts/src/providers/chart-context/chart-context.tsx	Created `ChartProvider` and `useChartContext`
projects/js-packages/charts/src/providers/chart-context/chart-context.test.tsx	Added tests for context hooks
projects/js-packages/charts/src/components/pie-semi-circle-chart/pie-semi-circle-chart.tsx	Wrapped component in `ChartProvider` and register via context
projects/js-packages/charts/src/components/pie-chart/pie-chart.tsx	Wrapped component in `ChartProvider` and register via context
projects/js-packages/charts/src/components/line-chart/line-chart.tsx	Wrapped component in `ChartProvider` and register via context; updated ID handling
projects/js-packages/charts/src/components/bar-chart/bar-chart.tsx	Wrapped component in `ChartProvider` and register via context; updated ID handling
projects/js-packages/charts/changelog/update-charts-49-chart-context-foundation	Added changelog entry for chart context foundation

Comments suppressed due to low confidence (1)

projects/js-packages/charts/src/components/pie-chart/pie-chart.tsx:123

Add a test case for the PieChart component to verify that it correctly registers itself with the context when rendered, and unregisters on unmount.

	useChartRegistration( chartId, legendItems, providerTheme, 'pie', {

projects/js-packages/charts/src/providers/chart-context/chart-context.tsx

projects/js-packages/charts/src/components/pie-semi-circle-chart/pie-semi-circle-chart.tsx

Define ChartRegistration interface for chart data storage and ChartContextValue interface for context API operations. Sets up foundation for chart registry system.

Create ChartProvider component with Map-based registry for chart data. Add useChartContext hook with error boundary for outside usage. Implement registerChart, unregisterChart, and getChartData methods.

Add useChartId hook for ID generation and resolution. Add useChartRegistration hook for chart lifecycle management. Support auto-generated IDs via React.useId() for unique identification.

Export ChartProvider and useChartContext from chart-context module. Export utility hooks useChartId and useChartRegistration. Export TypeScript types for external usage.

Add chartId prop for user-provided chart identifiers. Update JSDoc documentation for the new property. Maintains full backward compatibility with existing usage.

Wrap BarChart with ChartProvider for context registration. Register chart data with legend items, theme, and metadata on mount. Use memoized legend items for performance optimization. Maintain separate internal ID for pattern generation.

Wrap LineChart with ChartProvider for context registration. Register chart data including glyph options and gradient settings. Use memoized legend items with proper dependencies. Maintain separate internal ID for gradient generation.

Wrap PieChart with ChartProvider for context registration. Register chart data with metadata including thickness and gap options. Use memoized legend items for performance optimization. Support chart-specific configuration options in metadata.

Wrap PieSemiCircleChart with ChartProvider for context registration. Register chart data with semi-circle specific metadata options. Use memoized legend items with accessor dependencies. Support clockwise and thickness configuration in metadata.

Test provider functionality and error boundaries. Test chart registration and unregistration lifecycle. Test multiple chart independence and ID generation. Verify function reference stability and collision handling.

- Use provider theme instead of XY theme for registration - Fix TypeScript types in chart context tests - Fix ESLint import order and formatting issues 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

- Add metadata memoization in useChartRegistration to prevent unnecessary re-renders - Add displayName to LineChart and BarChart for better debugging in React DevTools - Maintain all necessary React hook imports (useContext, useEffect are used) 🤖 Generated with [Claude Code](https://claude.ai/code)

- Add isDataValid parameter to useChartRegistration hook - Only register charts with valid data to prevent invalid context entries - Maintain React hooks rules by calling all hooks in same order every render - Apply to all chart components: BarChart, LineChart, PieChart, PieSemiCircleChart 🤖 Generated with [Claude Code](https://claude.ai/code)

…context.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

annacmc requested a review from Copilot July 4, 2025 02:04

github-actions bot added [JS Package] Charts [Status] In Progress RNA labels Jul 4, 2025

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 4, 2025

This comment was marked as outdated.

Sign in to view

annacmc requested a review from Copilot July 4, 2025 04:18

annacmc self-assigned this Jul 4, 2025

Copilot AI reviewed Jul 4, 2025

View reviewed changes

projects/js-packages/charts/src/providers/chart-context/chart-context.tsx Outdated Show resolved Hide resolved

projects/js-packages/charts/src/components/pie-semi-circle-chart/pie-semi-circle-chart.tsx Outdated Show resolved Hide resolved

annacmc force-pushed the update/charts-49-chart-context-foundation branch 2 times, most recently from 76beea3 to 29635bb Compare July 7, 2025 01:07

annacmc mentioned this pull request Jul 9, 2025

Line chart - custom annotations #44131

Draft

3 tasks

annacmc and others added 15 commits July 9, 2025 16:33

Add ChartContext type definitions

30af6af

Define ChartRegistration interface for chart data storage and ChartContextValue interface for context API operations. Sets up foundation for chart registry system.

Implement ChartContext provider and hook

eb015bc

Create ChartProvider component with Map-based registry for chart data. Add useChartContext hook with error boundary for outside usage. Implement registerChart, unregisterChart, and getChartData methods.

Add chart ID and registration utilities

c902dbc

Add useChartId hook for ID generation and resolution. Add useChartRegistration hook for chart lifecycle management. Support auto-generated IDs via React.useId() for unique identification.

Export ChartContext public API

c80a469

Export ChartProvider and useChartContext from chart-context module. Export utility hooks useChartId and useChartRegistration. Export TypeScript types for external usage.

Add optional chartId to BaseChartProps

3c0c135

Add chartId prop for user-provided chart identifiers. Update JSDoc documentation for the new property. Maintains full backward compatibility with existing usage.

Add ChartContext integration to BarChart

5f65f49

Wrap BarChart with ChartProvider for context registration. Register chart data with legend items, theme, and metadata on mount. Use memoized legend items for performance optimization. Maintain separate internal ID for pattern generation.

Add ChartContext integration to LineChart

29bffb4

Wrap LineChart with ChartProvider for context registration. Register chart data including glyph options and gradient settings. Use memoized legend items with proper dependencies. Maintain separate internal ID for gradient generation.

Add ChartContext integration to PieChart

b62a2dd

Wrap PieChart with ChartProvider for context registration. Register chart data with metadata including thickness and gap options. Use memoized legend items for performance optimization. Support chart-specific configuration options in metadata.

Add ChartContext test coverage

5906575

Test provider functionality and error boundaries. Test chart registration and unregistration lifecycle. Test multiple chart independence and ID generation. Verify function reference stability and collision handling.

changelog

36e4aec

Update projects/js-packages/charts/src/providers/chart-context/chart-…

d79adff

…context.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

annacmc force-pushed the update/charts-49-chart-context-foundation branch from 16aefa0 to d79adff Compare July 9, 2025 06:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update/charts 49 chart context foundation #44189

Update/charts 49 chart context foundation #44189

annacmc commented Jul 4, 2025

Uh oh!

github-actions bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

jp-launch-control bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Update/charts 49 chart context foundation #44189

Are you sure you want to change the base?

Update/charts 49 chart context foundation #44189

Conversation

annacmc commented Jul 4, 2025

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

jp-launch-control bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 4, 2025 •

edited

Loading

github-actions bot commented Jul 4, 2025 •

edited

Loading

jp-launch-control bot commented Jul 4, 2025 •

edited

Loading