Skip to content

My Jetpack: Add CLAUDE.md file #44191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

gmjuhasz
Copy link
Contributor

@gmjuhasz gmjuhasz commented Jul 4, 2025

Fixes MYJP-204

Proposed changes:

  • Adds a project level Claude md file for Claude code

Other information:

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Sanity check of the file that it makes sense
  • You could try using Claude Code to see if it recognises the file, but that should be the case

@gmjuhasz gmjuhasz requested review from robertsreberski, a team and Copilot July 4, 2025 09:16
@gmjuhasz gmjuhasz self-assigned this Jul 4, 2025
@gmjuhasz gmjuhasz added the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Jul 4, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new CLAUDE.md file at the project level to provide guidance for Claude Code interactions, and adds a corresponding changelog entry.

  • Adds projects/packages/my-jetpack/changelog/add-my-jetpack-project-level-claude-md
  • Adds detailed projects/packages/my-jetpack/CLAUDE.md documentation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
projects/packages/my-jetpack/changelog/add-my-jetpack-project-level-claude-md Changelog entry for the new CLAUDE.md file
projects/packages/my-jetpack/CLAUDE.md Guidance and patterns for using Claude Code with this repository
Comments suppressed due to low confidence (1)

projects/packages/my-jetpack/CLAUDE.md:18

  • Grammar: change 'Must be ran' to 'Must be run' for clarity.
pnpm run test # Runs the REACT component tests. Must be ran from my-jetpack folder

Copy link
Contributor

github-actions bot commented Jul 4, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/my-jetpack/project-level-claude-md branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/my-jetpack/project-level-claude-md

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Jul 4, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 4, 2025
@gmjuhasz gmjuhasz added [Type] Task and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jul 4, 2025
Copy link

jp-launch-control bot commented Jul 4, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@gmjuhasz
Copy link
Contributor Author

gmjuhasz commented Jul 4, 2025

Thanks for the comments @jeherve, these are great ideas! I implemented them in 581af31. I linked documentations where applicable, and moved basic information over to my-jetpack's README

Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about the general conventions here, but a few general thoughts if we go this route:

  1. We should probably exclude CLAUDE.md from production in the monorepo root .gitattributes.
  2. The README.md target audience would typically be those that are downloading the package, and would be exposed in Packagist and the mirror repo. As such, relative references to files outside of this package is probably a bad idea, as those links would be broken. Those limitations shouldn't apply to CLAUDE.md if we implement item 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants