-
Notifications
You must be signed in to change notification settings - Fork 822
My Jetpack: Add CLAUDE.md file #44191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new CLAUDE.md file at the project level to provide guidance for Claude Code interactions, and adds a corresponding changelog entry.
- Adds
projects/packages/my-jetpack/changelog/add-my-jetpack-project-level-claude-md
- Adds detailed
projects/packages/my-jetpack/CLAUDE.md
documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
projects/packages/my-jetpack/changelog/add-my-jetpack-project-level-claude-md | Changelog entry for the new CLAUDE.md file |
projects/packages/my-jetpack/CLAUDE.md | Guidance and patterns for using Claude Code with this repository |
Comments suppressed due to low confidence (1)
projects/packages/my-jetpack/CLAUDE.md:18
- Grammar: change 'Must be ran' to 'Must be run' for clarity.
pnpm run test # Runs the REACT component tests. Must be ran from my-jetpack folder
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know anything about the general conventions here, but a few general thoughts if we go this route:
- We should probably exclude
CLAUDE.md
from production in the monorepo root.gitattributes
. - The
README.md
target audience would typically be those that are downloading the package, and would be exposed in Packagist and the mirror repo. As such, relative references to files outside of this package is probably a bad idea, as those links would be broken. Those limitations shouldn't apply toCLAUDE.md
if we implement item 1.
Fixes MYJP-204
Proposed changes:
Other information:
Does this pull request change what data or activity we track or use?
No.
Testing instructions: