SAL_Site: Prevent warnings due to reading properties on null #44195

coder-karen · 2025-07-04T14:00:52Z

Fixes VULCAN-228

Proposed changes:

This PR adds property checks within the user_can_view_post function, specifically with regard to checking the $parent_post, and therefore the $post_status_obj value. Both get_post and get_post_status_object can return null so we should allow for that, and ensure the rest of the code continues processing as before if these values are null.
What we are preventing are warnings that were being output in logs.

Logs: e1891edb5a21bf2c639db4455ebc23cc-logstash

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pdWQjU-1g0-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Code-review
You can also test this by visiting the URL mentioned in the Linear issue, and then on trunk observing a new entry in the above linked Logstash logs.
If you are have sandboxed https://public-api. wordpress.com/, you should also see an error while tailing for errors: tail -f /tmp/php-errors
You can confirm the change prevents the warning and doesn't impact the output by using the commands in the generated comment below and sandboxing https://public-api. wordpress.com/, while tailing for errors. No errors should be generated.

github-actions · 2025-07-04T14:01:41Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/class-json-api-site-base-prevent-prop-warnings branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/class-json-api-site-base-prevent-prop-warnings

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-07-04T14:01:47Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: August 5, 2025
- Code freeze: August 4, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2025-07-04T14:09:24Z

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

darssen · 2025-07-07T07:55:12Z

projects/plugins/jetpack/sal/class.json-api-site-base.php

+		if (
+		( 'trash' === $post->post_status && current_user_can( 'edit_post', $post->ID ) )
+		|| 'auto-draft' === $post->post_status
+		) {
+			$authorized = true;
+		}


Not a blocker, but we could check here if $authorized was already set to true, and not evaluate. Similar how it was before with the short-circuit logic.

Good idea - added in 4adf206

darssen

Thanks for working on this one @coder-karen

Changes look good from a code review perspective. Left a minor comment.

projects/plugins/jetpack/sal/class.json-api-site-base.php

darssen

LGTM 👍

Co-authored-by: Juanma Rodriguez Escriche <juanma.rodriguez.escriche@automattic.com>

coder-karen added 2 commits July 4, 2025 14:48

Prevent warnings due to reading properties on null

ab69e1e

changelog

651b65f

coder-karen self-assigned this Jul 4, 2025

coder-karen added [Type] Bug When a feature is broken and / or not performing as intended [Status] In Progress labels Jul 4, 2025

github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jul 4, 2025

coder-karen marked this pull request as ready for review July 4, 2025 16:18

coder-karen added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Jul 4, 2025

coder-karen requested a review from a team July 4, 2025 16:18

darssen reviewed Jul 7, 2025

View reviewed changes

Check if authorized is true before additional checks

4adf206

darssen reviewed Jul 7, 2025

View reviewed changes

projects/plugins/jetpack/sal/class.json-api-site-base.php Outdated Show resolved Hide resolved

darssen previously approved these changes Jul 7, 2025

View reviewed changes

Update projects/plugins/jetpack/sal/class.json-api-site-base.php

f1a600a

Co-authored-by: Juanma Rodriguez Escriche <juanma.rodriguez.escriche@automattic.com>

coder-karen dismissed darssen’s stale review via f1a600a July 7, 2025 09:15

coder-karen merged commit afe2063 into trunk Jul 7, 2025
67 checks passed

coder-karen deleted the update/class-json-api-site-base-prevent-prop-warnings branch July 7, 2025 11:54

github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jul 7, 2025

github-actions bot added this to the jetpack/14.9 milestone Jul 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

SAL_Site: Prevent warnings due to reading properties on null #44195

SAL_Site: Prevent warnings due to reading properties on null #44195

Uh oh!

coder-karen commented Jul 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

darssen Jul 7, 2025

Uh oh!

coder-karen Jul 7, 2025

Uh oh!

darssen left a comment

Uh oh!

Uh oh!

darssen left a comment

Uh oh!

Uh oh!

Uh oh!

SAL_Site: Prevent warnings due to reading properties on null #44195

SAL_Site: Prevent warnings due to reading properties on null #44195

Uh oh!

Conversation

coder-karen commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

darssen Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

coder-karen Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

darssen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

darssen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coder-karen commented Jul 4, 2025 •

edited

Loading

github-actions bot commented Jul 4, 2025 •

edited

Loading

github-actions bot commented Jul 4, 2025 •

edited

Loading

jp-launch-control bot commented Jul 4, 2025 •

edited

Loading