Forms: Display success info after form submission without reload #44204

dhasilva · 2025-07-04T23:33:46Z

Part of FORMS-69

Proposed changes:

Displays the submitted data without reload if the feature flag is on
Fixes forms on widgets and on paginated content (when the feature flag is on)
Does not deal with submission errors (network, mostly)
Does not deal with transitions

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Make sure the feature flag is disabled
Submit some forms. Test post forms, pages with more than one form, widgets...
Check that it works exactly the same as in trunk, with no regressions. Forms on widgets do not work on trunk, and forms on paginated posts (your Home, add some posts with forms in them) also do not work. This is expected, same as trunk.
Enable the flag with add_filter( 'jetpack_forms_enable_ajax_submission', '__return_true' );
Reload the pages and submit again. Test the same cases.
Check that the information is displayed without a reload on all cases
Check that you can go back and the form is displayed without a reload, in a reset state
Check that you can fill it and submit again
Check that emails are sent as expected
Check that the forms are displayed in the dashboard as expected

github-actions · 2025-07-04T23:34:33Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-submit-ajax-json-frontend branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/forms-submit-ajax-json-frontend

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-07-04T23:34:40Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

jp-launch-control · 2025-07-04T23:42:56Z

Code Coverage Summary

Coverage changed in 6 files. Only the first 5 are listed here.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form.php	588/1063 (55.32%)	-2.21%	46 💔
projects/packages/forms/src/modules/form/view.js	0/194 (0.00%)	0.00%	39 💔
projects/packages/forms/src/modules/form/shared.js	0/30 (0.00%)	0.00%	3 ❤️‍🩹
projects/packages/forms/src/modules/file-field/view.js	0/163 (0.00%)	0.00%	2 ❤️‍🩹
projects/packages/forms/src/contact-form/class-contact-form-field.php	601/1026 (58.58%)	-0.06%	1 ❤️‍🩹

Full summary · PHP report · JS report

_{Coverage check overridden by

Coverage tests to be added later
Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR
.}

simison · 2025-07-07T08:57:04Z

projects/packages/forms/src/contact-form/class-contact-form.php

+	 */
+	private static function render_ajax_success_wrapper( $form ) {
+		$html  = '<div class="contact-form-submission contact-form-ajax-submission" data-wp-class--is-submitted="state.hasSubmitted"';
+		$html .= '<p class="go-back-message"> <a class="link" href="#" data-wp-on--click="actions.goBack">' . esc_html__( 'Go back', 'jetpack-forms' ) . '</a> </p>';


Are the CSS classes these for backwards compatibility, or would it make sense to add jetpack- prefix to scope them better?

Those are for backwards compatibility, yes. That is almost a copy of the current post-submission screen.

simison · 2025-07-07T08:57:45Z

projects/packages/forms/src/contact-form/class-contact-form.php

+
+		if ( 'message' === $form->get_attribute( 'customThankyou' ) ) {
+			$raw_message = wpautop( $form->get_attribute( 'customThankyouMessage' ) );
+			// Add more allowed HTML elements for file download links


Why be restrictive here at all instead of just using wp_kses()'s default restrictions?

That is the current implementation on the post-submission screen. The idea is to match it as well as possible, so I copied it over.

Makes sense then 👍

simison · 2025-07-07T09:01:44Z

projects/packages/forms/src/contact-form/class-contact-form.php

+		} else {
+			$html .= '<template data-wp-each--submission="state.getSubmissionData">
+				<div class="field-name" data-wp-text="context.submission.label" data-wp-bind--hidden="!context.submission.label"></div>
+				<div class="field-value" data-wp-text="context.submission.value"></div>


Same as https://github.com/Automattic/jetpack/pull/44204/files#r2189419246 — any reason not to prefix class with jetpack-? This one is particularly generic and can collide with theme/other plugins.

We can prefix them, yes. I just need to make sure the prefixed classes also work on the current screen. Will add it in this PR.

dhasilva requested a review from a team July 4, 2025 23:33

dhasilva self-assigned this Jul 4, 2025

dhasilva added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR labels Jul 4, 2025

github-actions bot added [Feature] Contact Form [Package] Forms labels Jul 4, 2025

simison reviewed Jul 7, 2025

View reviewed changes

dhasilva added 6 commits July 9, 2025 12:11

refactor feature flag check

8e7b535

move interactivity api context to form wrapper

13c1bf1

display results without refresh

5d6cb8a

changelog

a5a6628

fix css display

0eee8f5

fix hidden form on shortcodes

c0bf111

dhasilva force-pushed the update/forms-submit-ajax-json-frontend branch from 4318546 to c0bf111 Compare July 9, 2025 15:29

dhasilva added 9 commits July 10, 2025 20:50

change to wp-ajax endpoint

8b09522

add entry title to non-post forms

9291356

fix phan issue

2f30fd6

fix form reset

e0d0078

scroll after submission or going back

dd876ea

fix form submission on paginated context

f378e86

fix multistep form reset

54f23ef

fix display value of file fields

b5daaf5

reset files

c6b5f66

dhasilva removed the [Status] In Progress label Jul 11, 2025

dhasilva added the [Status] Needs Review This PR is ready for review. label Jul 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Forms: Display success info after form submission without reload #44204

Forms: Display success info after form submission without reload #44204

dhasilva commented Jul 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 4, 2025

Uh oh!

jp-launch-control bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

simison Jul 7, 2025

Uh oh!

dhasilva Jul 9, 2025

Uh oh!

simison Jul 7, 2025 •

edited

Loading

Uh oh!

dhasilva Jul 9, 2025

Uh oh!

simison Jul 9, 2025

Uh oh!

simison Jul 7, 2025 •

edited

Loading

Uh oh!

dhasilva Jul 9, 2025

Uh oh!

Uh oh!

Forms: Display success info after form submission without reload #44204

Are you sure you want to change the base?

Forms: Display success info after form submission without reload #44204

Conversation

dhasilva commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 4, 2025

Uh oh!

jp-launch-control bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

simison Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

dhasilva Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

simison Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dhasilva Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

simison Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

simison Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dhasilva Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dhasilva commented Jul 4, 2025 •

edited

Loading

github-actions bot commented Jul 4, 2025 •

edited

Loading

jp-launch-control bot commented Jul 4, 2025 •

edited

Loading

simison Jul 7, 2025 •

edited

Loading

simison Jul 7, 2025 •

edited

Loading