Skip to content

A4A > Reports: CFT UI enhancements Part 2 #104615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Jul 7, 2025

Resolves https://linear.app/a8c/issue/A4A-1235/reports-cft-report-builder-enhancements
Resolves https://linear.app/a8c/issue/A4A-1239/reports-cft-show-client-emails-on-the-preview-panel
Resolves https://linear.app/a8c/issue/A4A-1238/reports-cft-fix-the-disabled-select-site-buttons-broken-hover-effect

Proposed Changes

This PR

  • Updates the texts on the Report Builder
  • Shows the client emails on the reports dashboard
  • Fix the disabled primary button color

Why are these changes being made?

  • UI enhancements and address CFT feedback

Testing Instructions

  • Open the A4A live link
  • Go to Reports > Build a new report > Click the select site button > Verify that the "disabled" state of the button (default and hover) is updated
Before After
Screenshot 2025-07-07 at 11 21 20 AM Screenshot 2025-07-07 at 11 21 35 AM
  • Verify that the first step has a help text above the button
Screenshot 2025-07-07 at 10 25 57 AM
  • Proceed to create a new report > Verify the text on the loading state on step 3 is updated as shown below
Screenshot 2025-07-07 at 10 26 17 AM
  • Go to Reports: Dashboard: open the detailed view of any site > Verify the client emails are displayed as shown below
Desktop Mobile
Screenshot 2025-07-07 at 10 52 54 AM Screenshot 2025-07-07 at 11 03 06 AM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@yashwin yashwin requested a review from a team July 7, 2025 06:22
@yashwin yashwin self-assigned this Jul 7, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 7, 2025
Copy link

github-actions bot commented Jul 7, 2025

@matticbot
Copy link
Contributor

matticbot commented Jul 7, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~299 bytes added 📈 [gzipped])

name                      parsed_size           gzip_size
a8c-for-agencies-reports      +1123 B  (+0.1%)     +299 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@yashwin yashwin changed the title A4A > Reports: CFT UI Enhancements Part 2 A4A > Reports: CFT UI enhancements Part 2 Jul 7, 2025
@yashwin yashwin changed the base branch from trunk to update/a4a/reports/cft/ui-enhancements-2 July 7, 2025 06:25
@matticbot
Copy link
Contributor

matticbot commented Jul 7, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/a4a/reports/cft/ui-enhancements-3 on your sandbox.

Copy link
Contributor

@cleacos cleacos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yashwin yashwin force-pushed the update/a4a/reports/cft/ui-enhancements-2 branch from 4c30edf to fe30081 Compare July 8, 2025 03:42
Base automatically changed from update/a4a/reports/cft/ui-enhancements-2 to trunk July 8, 2025 04:29
@yashwin yashwin force-pushed the update/a4a/reports/cft/ui-enhancements-3 branch from 73faaf2 to 4af01cb Compare July 8, 2025 04:46
@yashwin yashwin merged commit affdcb6 into trunk Jul 8, 2025
12 checks passed
@yashwin yashwin deleted the update/a4a/reports/cft/ui-enhancements-3 branch July 8, 2025 05:14
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 8, 2025
@a8ci18n
Copy link

a8ci18n commented Jul 8, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/19395027

Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @yashwin for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants