-
Notifications
You must be signed in to change notification settings - Fork 2k
Wire onInvalidAuth to return jwt #104619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Wire onInvalidAuth to return jwt #104619
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~29 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~62 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing, I think we should pass the query client to initSmooch
. Then invalidate the cache and call queryClient.fetchQuery
instead. Otherwise the bad token will stay in the cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simulated an expired JWT token by giving the token a short exp
value and this worked like a charm.
Part of #
We weren't handling auth issues for users effectively.
We added logging for
onInvalidAuth
and noticed that customers are triggering the logging.This PR wires it properly so that a new JWT token is generated.
Proposed Changes
Why are these changes being made?
Testing Instructions
class-help-authentication
change theexp
totime() + 2 * MINUTE_IN_SECONDS
to force the token to expire quicklyPre-merge Checklist