Skip to content

Wire onInvalidAuth to return jwt #104619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Wire onInvalidAuth to return jwt #104619

wants to merge 3 commits into from

Conversation

heavyweight
Copy link
Contributor

@heavyweight heavyweight commented Jul 7, 2025

Part of #

We weren't handling auth issues for users effectively.
We added logging for onInvalidAuth and noticed that customers are triggering the logging.
This PR wires it properly so that a new JWT token is generated.

Before After
Screenshot 2025-07-07 at 10 29 52 Screenshot 2025-07-07 at 10 15 35

Proposed Changes

  • Wire onInvalidAuth to return jwt

Why are these changes being made?

  • Solve zd auth issues for users

Testing Instructions

  • Checkout this PR
  • On your sandbox for class-help-authentication change the exp to time() + 2 * MINUTE_IN_SECONDS to force the token to expire quickly
  • Open an incognito window and login with your testing user
  • Open the help center
  • Open an active chat with ZD or create a new one
  • Leave the chat open for more than 2 minutes
  • Write a message in the chat
  • Notice that the first network request to send the message fails, a call to generate the token is made, and the message request is retried
  • Open the chat in ZD and verify that the message was delivered

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Copy link

github-actions bot commented Jul 7, 2025

@matticbot
Copy link
Contributor

matticbot commented Jul 7, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/hc-auth-issues on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jul 7, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~29 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
plans                                    +42 B  (+0.0%)      +12 B  (+0.0%)
jetpack-connect                          +42 B  (+0.0%)      +12 B  (+0.0%)
jetpack-cloud-pricing                    +42 B  (+0.0%)      +12 B  (+0.0%)
jetpack-cloud-features-comparison        +42 B  (+0.0%)       +8 B  (+0.0%)
checkout                                 +42 B  (+0.0%)       +9 B  (+0.0%)
a8c-for-agencies-client                  +42 B  (+0.0%)       +9 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~62 bytes added 📈 [gzipped])

name                                              parsed_size           gzip_size
async-load-help-center-app                             +220 B  (+0.0%)      +61 B  (+0.0%)
async-load-automattic-help-center                      +220 B  (+0.0%)      +61 B  (+0.0%)
async-load-calypso-components-jetpack-portal-nav        +42 B  (+0.1%)       +1 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@heavyweight heavyweight marked this pull request as ready for review July 7, 2025 08:32
@heavyweight heavyweight requested a review from a team as a code owner July 7, 2025 08:32
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 7, 2025
Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, I think we should pass the query client to initSmooch. Then invalidate the cache and call queryClient.fetchQuery instead. Otherwise the bad token will stay in the cache.

Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simulated an expired JWT token by giving the token a short exp value and this worked like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants