Skip to content

Fix login form not having padding on mobile #104621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025
Merged

Fix login form not having padding on mobile #104621

merged 2 commits into from
Jul 8, 2025

Conversation

xavier-lc
Copy link
Contributor

@xavier-lc xavier-lc commented Jul 7, 2025

Fixes DOTCOM-13807

Proposed Changes

  • Bring back the side padding to the login form for mobile apps.

Why are these changes being made?

Testing Instructions

  • Open the live preview
  • Open dev tools, enable responsive view
  • Go to /log-in?client_id=2697&redirect_to=https%3A%2F%2Fpublic-api.wordpress.com%2Foauth2%2Fauthorize%3Fclient_id%3D2697%26redirect_uri%3Dwordpress%253A%252F%252Fwpcom-authorize%26response_type%3Dcode%26scope%3Dglobal%26from-calypso%3D1 (the link you would get if trying to log in on the wordpress mobile app for android)
  • Check that the header and footer links, terms of service text, and the Back button have been removed.
  • Repeat with /log-in?client_id=11&redirect_to=https%3A%2F%2Fpublic-api.wordpress.com%2Foauth2%2Fauthorize%3Fclient_id%3D11%26redirect_uri%3Dwordpress%253A%252F%252Fwpcom-authorize%26response_type%3Dcode%26scope%3Dglobal%26from-calypso%3D1 (the link you would get if trying to log in on the wordpress mobile app for iOs)
Before After
image image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@xavier-lc xavier-lc self-assigned this Jul 7, 2025
Copy link

github-actions bot commented Jul 7, 2025

@matticbot
Copy link
Contributor

matticbot commented Jul 7, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~17 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-reauth-required        +34 B  (+0.0%)      +17 B  (+0.0%)
entry-main                   +34 B  (+0.0%)      +17 B  (+0.0%)
entry-login                  +34 B  (+0.0%)      +17 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@xavier-lc xavier-lc requested review from crazytonyli and a team July 7, 2025 10:09
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 7, 2025
Copy link
Member

@mmtr mmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well!

Copy link
Contributor

@dsas dsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does what it says, but it looks like other pages have a similar issue, here's the "Lost your password" screen:
Screenshot 2025-07-07 at 11 33 57

@xavier-lc
Copy link
Contributor Author

This change does what it says, but it looks like other pages have a similar issue, here's the "Lost your password" screen:

Good catch, I've addressed it as well.

@xavier-lc xavier-lc requested a review from dsas July 7, 2025 14:05
Copy link
Contributor

@BogdanUngureanu BogdanUngureanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well for me (including lost password page)!

@xavier-lc xavier-lc merged commit 0cf851d into trunk Jul 8, 2025
9 of 11 checks passed
@xavier-lc xavier-lc deleted the DOTCOM-13807 branch July 8, 2025 10:40
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants