Skip to content

Staging Sites Redesign: Add information component on staging site management move #104625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 9, 2025

Conversation

ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented Jul 7, 2025

Resolves DOTDEV-182

Proposed Changes

  • add temporary information component describing staging site management move

Markup on 2025-07-08 at 20:07:32

design in Figma: ASqz3fW9Go9m5bHL2XiuUR-fi-724_136351

Why are these changes being made?

DOTDEV-182

Testing Instructions

  1. Check out the PR branch and build the app with yarn start (or use Calypso Live).
  2. Ensure the hosting/staging-sites-redesign feature flag is enabled (by using ?flags=hosting/staging-sites-redesign query parameter).
  3. Head over to the /sites dashboard and select an Atomic test site with a staging site.
  4. Click on the Staging site tab. Instead of staging site management buttons a new information tab content should be rendered (as can be seen in the screenshot above). The content should be clear and make sense.
  5. The same content should be rendered for staging and production site.
  6. Content should render correctly on mobile and RTL as well.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@ivan-ottinger ivan-ottinger self-assigned this Jul 7, 2025
Copy link

github-actions bot commented Jul 7, 2025

@matticbot
Copy link
Contributor

matticbot commented Jul 7, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1677 bytes added 📈 [gzipped])

name          parsed_size           gzip_size
staging-site      +5270 B  (+0.4%)    +1677 B  (+0.4%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@ivan-ottinger ivan-ottinger force-pushed the add/staging-site-management-move-info branch from a49054a to e8be278 Compare July 8, 2025 10:35
@matticbot
Copy link
Contributor

matticbot commented Jul 8, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/staging-site-management-move-info on your sandbox.

@ivan-ottinger ivan-ottinger marked this pull request as ready for review July 8, 2025 18:08
@ivan-ottinger ivan-ottinger requested a review from a team July 8, 2025 18:10
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 8, 2025
Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ivan! I have tested it, and it works as expected. I can see the new page displayed and it behaves as expected at different screen sizes and in mobile. LGTM! 🚢

Staging Production RTL
CleanShot 2025-07-09 at 12 35 59@2x CleanShot 2025-07-09 at 12 36 04@2x CleanShot 2025-07-09 at 12 37 07@2x

@ivan-ottinger ivan-ottinger merged commit 19653e8 into trunk Jul 9, 2025
13 checks passed
@ivan-ottinger ivan-ottinger deleted the add/staging-site-management-move-info branch July 9, 2025 12:13
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 9, 2025
@a8ci18n
Copy link

a8ci18n commented Jul 9, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/19409301

Some locales (Brazilian Portuguese, Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @ivan-ottinger for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants