feat(route): add eventbrite #19007
Open
feat(route): add eventbrite #19007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Successfully generated as following: http://localhost:1200/eventbrite/all-events/canada--toronto - Failed ❌ |
TonyRL
reviewed
May 5, 2025
|
Successfully generated as following: http://localhost:1200/eventbrite/all-events/canada--toronto - Failed ❌ |
|
Successfully generated as following: http://localhost:1200/eventbrite/all-events/canada--toronto - Failed ❌ |
|
Addressed comments, however I still want this to support the .ca domain before merging as people in Canada like me will be using the .ca event brite not the .com |
|
Successfully generated as following: http://localhost:1200/eventbrite/all-events/canada--toronto - Failed ❌ |
TonyRL
reviewed
May 19, 2025
Comment on lines
+22
to
+25
| { | ||
| source: ['eventbrite.com/d/:region/:eventType', 'eventbrite.ca/d/:region/:eventType'], | ||
| target: '/:region/:eventType', | ||
| }, |
There was a problem hiding this comment.
Suggested change
| { | |
| source: ['eventbrite.com/d/:region/:eventType', 'eventbrite.ca/d/:region/:eventType'], | |
| target: '/:region/:eventType', | |
| }, | |
| { | |
| source: ['eventbrite.com/d/:region/:eventType'], | |
| target: '/:region/:eventType', | |
| }, | |
| { | |
| source: ['eventbrite.ca/d/:region/:eventType'], | |
| target: '/:region/:eventType', | |
| }, |
Comment on lines
+38
to
+40
| headers: { | ||
| 'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:138.0) Gecko/20100101 Firefox/138.0', | ||
| }, |
There was a problem hiding this comment.
Does the site only work on this fixed version of Firefox on Windows? If the answer is no, please remove it which RSSHub will use a randomised Chrome on macOS by default.
Comment on lines
+63
to
+64
| title: `should be ${fallbackTitle}`, | ||
| author: pElements.length > 1 ? `should be ${$(pElements[1]).text()}` : 'unknown author', |
There was a problem hiding this comment.
Do not use should be or unknown author. Leave it undefined if you don't know.
| description: eventData.summary, | ||
| id: eventData.eventbrite_event_id, | ||
| content: { | ||
| html: `${eventDate(eventData)}\n${getAuthor(eventData)}\n${getTicketPriceRange(eventData)}`, |
There was a problem hiding this comment.
Suggested change
| html: `${eventDate(eventData)}\n${getAuthor(eventData)}\n${getTicketPriceRange(eventData)}`, | |
| html: `${eventDate(eventData)}<br>${getAuthor(eventData)}<br>${getTicketPriceRange(eventData)}`, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Involved Issue / 该 PR 相关 Issue
N/A
Example for the Proposed Route(s) / 路由地址示例
New RSS Route Checklist / 新 RSS 路由检查表
PuppeteerNote / 说明
I don't know how to scope the radar to work on eventbrite.ca as well.
Future Improvements